refactor: small code optimizations

Author: D3SOX

src/auto.ts

@@ -1,4 +1,4 @@
-import { Snapshot, Settings, AutoMode, QueueUpdateEvent, OnProgressEvent } from "./types";
+import type { Snapshot, Settings, AutoMode, QueueUpdateEvent, OnProgressEvent } from "./types";
 import { getQueueFromSpicetify } from "./queue";
 import { areQueuesEqual, generateId } from "./utils";
 import { addSnapshot, getSortedSnapshots, loadSnapshots, saveSnapshots, saveSettings } from "./storage";

src/dialogs.ts

@@ -1,4 +1,4 @@
-import { ButtonTone } from "./types";
+import type { ButtonTone } from "./types";
 import { t } from "./i18n";
 
 type ConfirmDialogOptions = {

src/exporter.ts

@@ -1,4 +1,4 @@
-import { Snapshot } from "./types";
+import type { Snapshot } from "./types";
 import { getSnapshotDisplayName, getSnapshotGeneratedNameFor } from "./names";
 import { getQueueFromSpicetify } from "./queue";
 import { addSnapshot, loadSettings } from "./storage";
@@ -202,17 +202,17 @@ export async function appendSnapshotToQueue(snapshot: Snapshot, buttonEl?: HTMLB
   }
 }
 
-export async function replaceQueueWithSnapshot(snapshot: Snapshot, buttonEl?: HTMLButtonElement, uiHandlers?: UIHandlers): Promise<boolean> {
+export async function replaceQueueWithSnapshot(snapshot: Snapshot, buttonEl?: HTMLButtonElement, uiHandlers?: UIHandlers): Promise<void> {
   try {
     if (!snapshot.items.length) {
       showWarningToast(t('toasts.snapshotEmpty'));
-      return false;
+      return;
     }
 
     // Check if the current queue already matches the snapshot - if so, skip replacement
     const currentQueue = getQueueFromSpicetify();
     if (areQueuesEqual(currentQueue, snapshot.items)) {
-      return false;
+      return;
     }
 
     // Prompt to save current queue before activation if this is a synced snapshot being activated
@@ -228,7 +228,7 @@ export async function replaceQueueWithSnapshot(snapshot: Snapshot, buttonEl?: HT
         tone: "primary",
       });
       if (shouldSave === "extra") {
-        return false;
+        return;
       }
       if (shouldSave === "confirm") {
         await createManualSnapshot();

src/importer.ts

@@ -1,10 +1,10 @@
 import { showConfirmDialog } from "./dialogs";
 import { loadSnapshots, saveSnapshots } from "./storage";
 import { showErrorToast, showSuccessToast } from "./toast";
-import { Settings, Snapshot } from "./types";
+import type { Settings, Snapshot } from "./types";
 import { uploadJson } from "./utils";
 import { renderList, renderSettings } from "./ui";
-import { UIHandlers } from "./ui";
+import type { UIHandlers } from "./ui";
 import { t } from "./i18n";
 
 function isValidSnapshot(s: any): s is Snapshot {

src/main.ts

@@ -1,6 +1,6 @@
-import { Settings } from "./types";
+import type { Settings } from "./types";
 import { loadSettings, saveSettings } from "./storage";
-import { openManagerModal, UIHandlers } from "./ui";
+import { openManagerModal, type UIHandlers } from "./ui";
 import { createAutoManager, createQueueCapacityWatcher, createQueueSyncManager } from "./auto";
 import { APP_NAME } from "./appInfo";
 import { t } from "./i18n";

src/queue.ts

@@ -28,7 +28,7 @@ export function getQueueFromSpicetify(): string[] {
     if (current) list.push(current);
 
     const nextArr = q?.nextTracks || [];
-    let queuedCount = 0;
+    // let queuedCount = 0;
     for (const it of Array.isArray(nextArr) ? nextArr : []) {
       const provider: string | undefined = it?.provider;
       const meta = it?.contextTrack?.metadata || it?.metadata;
@@ -38,7 +38,7 @@ export function getQueueFromSpicetify(): string[] {
       const uri = getTrackUri(it);
       if (uri) {
         list.push(uri);
-        queuedCount++;
+        // queuedCount++;
       }
     }
     const out = list.length ? dedupeConsecutive(list) : [];

src/storage.ts

@@ -1,4 +1,4 @@
-import { Settings, Snapshot } from "./types";
+import type { Settings, Snapshot } from "./types";
 
 const SETTINGS_KEY = "queue-manager:settings";
 const DEFAULT_SETTINGS: Settings = {

src/ui.ts

@@ -1,6 +1,6 @@
 import "./ui.css";
 
-import { Snapshot, Settings, ButtonRenderOptions, BadgeVariant } from "./types";
+import type { Snapshot, Settings, ButtonRenderOptions, BadgeVariant } from "./types";
 import { loadSnapshots, pruneAutosToMax, saveSnapshots, clearAutoSnapshots, loadSettings, saveSettings, getSyncedSnapshots } from "./storage";
 import { getSnapshotItemNames, getSnapshotDisplayName, getSnapshotGeneratedNameFor } from "./names";
 import { escapeHtml, downloadJson, setButtonLabel, getIconMarkup, setButtonIcon, generateId, areQueuesEqual } from "./utils";
@@ -9,7 +9,7 @@ import { createManualSnapshot, exportSnapshotToPlaylist, replaceQueueWithSnapsho
 import { APP_CHANNEL, APP_NAME, APP_NAME_SLUG, APP_VERSION } from "./appInfo";
 import { getSortedSnapshots } from "./storage";
 import { showConfirmDialog, showPromptDialog } from "./dialogs";
-import { createQueueSyncManager } from "./auto";
+import type { createQueueSyncManager } from "./auto";
 import { importSettings, importSnapshots } from "./importer";
 import { t, refreshLocale } from "./i18n";
 import { getQueueFromSpicetify } from "./queue";

src/utils.ts

@@ -1,5 +1,5 @@
 import { APP_NAME } from "./appInfo";
-import { showErrorToast, showSuccessToast, showWarningToast } from "./toast";
+import { showErrorToast, showSuccessToast } from "./toast";
 import { t } from "./i18n";
 export const DEFAULT_ICON_SIZE = 16;