add proper sorting for appt date + time by casting to int (#3470)

* add proper sorting for appt date + time by casting to int

* f off timezone

Author: colinxfleming

app/helpers/patients_helper.rb

@@ -209,4 +209,14 @@ def appointment_date_display(patient)
     end
     return day
   end
+
+  def appointment_date_sort_value(patient)
+    return 0 unless patient.appointment_date.present?
+
+    timestamp = patient.appointment_date.to_time
+    if patient.appointment_time
+      timestamp = timestamp.change(hour: patient.appointment_time.hour, min: patient.appointment_time.min)
+    end
+    timestamp.to_i
+  end
 end

app/views/dashboards/_table_content.html.erb

@@ -45,7 +45,7 @@
           </td>
 
           <td><%= patient.status %></td>
-          <td><%= appointment_date_display patient %></td>
+          <td data-sort-value="<%= appointment_date_sort_value patient %>"><%= appointment_date_display patient %></td>
           <td><%= patient.most_recent_note_display_text %> </td>
 
           <% if table_type == 'completed_calls' || table_type == 'shared_cases' %>

test/helpers/patients_helper_test.rb

@@ -350,4 +350,18 @@ class PatientsHelperTest < ActionView::TestCase
       assert_equal '10/31/2022 @ 5:30 PM (multi-day)', appointment_date_display(@patient)
     end
   end
+
+  describe 'appointment_date_sort_value' do
+    it 'should show appointment date and time as an int' do
+      @patient = create :patient
+      assert_equal 0, appointment_date_sort_value(@patient)
+
+      @patient.appointment_date = Time.new 2022, 10, 31
+      just_date = appointment_date_sort_value(@patient)
+      assert 1660000000 < just_date
+
+      @patient.appointment_time = '17:30'
+      assert just_date < appointment_date_sort_value(@patient)
+    end
+  end
 end