refactor: 필드 변경에 따른 코드 구조 변경 (DASOMBE-21)

si-zero · si-zero · commit 9ec4a2689812 · 2025-08-28T09:58:21.000+09:00
diff --git a/src/main/java/dmu/dasom/api/domain/executive/dto/ExecutiveListResponseDto.java b/src/main/java/dmu/dasom/api/domain/executive/dto/ExecutiveListResponseDto.java
@@ -1,5 +1,6 @@
 package dmu.dasom.api.domain.executive.dto;
 
+import dmu.dasom.api.domain.executive.enums.Team;
 import io.swagger.v3.oas.annotations.media.Schema;
 import lombok.AllArgsConstructor;
 import lombok.Builder;
@@ -22,7 +23,15 @@ public class ExecutiveListResponseDto {
     @Schema(description = "임원진 직책", example = "회장")
     private String position;
 
-    @Schema(description = "임원진 깃허브 주소", example = "https://github.com/dasom")
-    private String githubUrl;
+    @Schema(description = "수정할 임원진 역할", example = "동아리 운영 총괄", nullable = true)
+    private String role;
+
+    @Schema(description = "임원진 깃허브 이름", example = "DASOM")
+    private String github_username;
+
+    @Schema(description = "소속 팀", example = "president, tech, academic, pr, management")
+    private Team team;
+
+    private Integer sortOrder;
 
 }
diff --git a/src/main/java/dmu/dasom/api/domain/executive/dto/ExecutiveRequestDto.java b/src/main/java/dmu/dasom/api/domain/executive/dto/ExecutiveRequestDto.java
@@ -1,6 +1,7 @@
 package dmu.dasom.api.domain.executive.dto;
 
 import dmu.dasom.api.domain.executive.entity.ExecutiveEntity;
+import dmu.dasom.api.domain.executive.enums.Team;
 import io.swagger.v3.oas.annotations.media.Schema;
 import jakarta.validation.constraints.NotBlank;
 import jakarta.validation.constraints.Size;
@@ -21,17 +22,27 @@ public class ExecutiveRequestDto {
     @Schema(description = "임원진 이름", example = "김다솜")
     private String name;
 
-    @NotBlank(message = "임원진 역할은 필수 입력 사항입니다.")
-    @Schema(description = "임원진 역할", example = "회장")
+    @NotBlank(message = "임원진 직책은 필수 입력 사항입니다.")
+    @Schema(description = "임원진 직책", example = "회장")
     private String position;
 
-    private String githubUrl;
+    @NotBlank(message = "임원진 역할은 필수 입력 사항입니다.")
+    @Schema(description = "임원진 역할", example = "동아리 운영 총괄")
+    private String role;
+
+    @Schema(description = "임원진 깃허브 이름", example = "DASOM")
+    private String github_username;
+
+    @Schema(description = "소속 팀", example = "president, tech, academic, pr, management")
+    private Team team;
+
+    private Integer sortOrder;
 
     public ExecutiveEntity toEntity() {
         return ExecutiveEntity.builder()
                 .name(this.name)
                 .position(this.position)
-                .githubUrl(this.githubUrl)
+                .role
                 .build();
     }
 }
diff --git a/src/main/java/dmu/dasom/api/domain/executive/dto/ExecutiveResponseDto.java b/src/main/java/dmu/dasom/api/domain/executive/dto/ExecutiveResponseDto.java
@@ -1,5 +1,6 @@
 package dmu.dasom.api.domain.executive.dto;
 
+import dmu.dasom.api.domain.executive.enums.Team;
 import io.swagger.v3.oas.annotations.media.Schema;
 import lombok.AllArgsConstructor;
 import lombok.Builder;
@@ -22,6 +23,14 @@ public class ExecutiveResponseDto {
     @Schema(description = "임원진 직책", example = "회장")
     private String position;
 
-    @Schema(description = "임원진 깃허브", example = "https://github.com/dasom")
-    private String githubUrl;
+    @Schema(description = "수정할 임원진 역할", example = "동아리 운영 총괄")
+    private String role;
+
+    @Schema(description = "임원진 깃허브 이름", example = "DASOM")
+    private String github_username;
+
+    @Schema(description = "소속 팀", example = "president, tech, academic, pr, management")
+    private Team team;
+
+    private Integer sortOrder;
 }
diff --git a/src/main/java/dmu/dasom/api/domain/executive/dto/ExecutiveUpdateRequestDto.java b/src/main/java/dmu/dasom/api/domain/executive/dto/ExecutiveUpdateRequestDto.java
@@ -1,5 +1,6 @@
 package dmu.dasom.api.domain.executive.dto;
 
+import dmu.dasom.api.domain.executive.enums.Team;
 import io.swagger.v3.oas.annotations.media.Schema;
 import jakarta.validation.constraints.Size;
 import lombok.AllArgsConstructor;
@@ -19,6 +20,15 @@ public class ExecutiveUpdateRequestDto {
     @Schema(description = "수정할 임원진 직책", example = "회장", nullable = true)
     private String position;
 
-    @Schema(description = "수정할 임원진 깃허브 주소", example = "https://github.com/dasom", nullable = true)
-    private String githubUrl;
+    @Schema(description = "수정할 임원진 역할", example = "동아리 운영 총괄", nullable = true)
+    private String role;
+
+    @Schema(description = "임원진 깃허브 이름", example = "DASOM")
+    private String github_username;
+
+    @Schema(description = "소속 팀", example = "president, tech, academic, pr, management")
+    private Team team;
+
+    private Integer sortOrder;
+
 }
diff --git a/src/main/java/dmu/dasom/api/domain/executive/entity/ExecutiveEntity.java b/src/main/java/dmu/dasom/api/domain/executive/entity/ExecutiveEntity.java
@@ -3,9 +3,12 @@
 import dmu.dasom.api.domain.common.BaseEntity; // BaseEntity 상속 받음
 import dmu.dasom.api.domain.executive.dto.ExecutiveListResponseDto;
 import dmu.dasom.api.domain.executive.dto.ExecutiveResponseDto;
+import dmu.dasom.api.domain.executive.dto.ExecutiveUpdateRequestDto;
+import dmu.dasom.api.domain.executive.enums.Team;
 import io.swagger.v3.oas.annotations.media.Schema;
 import jakarta.persistence.*; // JPA 어노테이션 패키지 ( DB 매핑 관련 )
 import lombok.*; // 보일러플레이트 코드 자동 생성 라이브러리
+import org.checkerframework.checker.units.qual.C;
 
 @Getter
 @Entity
@@ -28,15 +31,31 @@ public class ExecutiveEntity extends BaseEntity {
     @Column(nullable=false, length = 50)
     private String position;
 
-    // 깃허브 주소
-    @Column(nullable=false, length = 255)
-    private String githubUrl;
+    // 역할
+    @Column(nullable = false, length = 50)
+    private String role;
+
+    // 깃허브 이름
+    @Column(name = "github_username")
+    private String githubUsername;
+
+    // 소속팀 (president/tech/academic/pr/management)
+    @Enumerated(EnumType.STRING)
+    @Column(nullable = false, length = 20)
+    private Team team;
+
+    @Column(name = "sort_order", nullable = false)
+    @Builder.Default
+    private Integer sortOrder = 9999;
 
     // 엔티티 업데이트 메소드
-    public void update(String name, String position, String githubUrl) {
-        this.name = name;
-        this.position = position;
-        this.githubUrl = githubUrl;
+    public void update(ExecutiveUpdateRequestDto dto) {
+        if (dto.getName() != null) this.name = dto.getName();
+        if (dto.getPosition() != null) this.position = dto.getPosition();
+        if (dto.getRole() != null) this.role = dto.getRole();
+        if (dto.getGithub_username() != null) this.githubUsername = dto.getGithub_username();
+        if (dto.getTeam() != null) this.team = dto.getTeam();
+        if (dto.getSortOrder() != null) this.sortOrder = dto.getSortOrder();
     }
 
     // 엔티티 -> DTO 변환 책임
@@ -45,7 +64,9 @@ public ExecutiveResponseDto toResponseDto() {
                 .id(this.id)
                 .name(this.name)
                 .position(this.position)
-                .githubUrl(this.githubUrl)
+                .role(this.role)
+                .github_username(this.githubUsername)
+                .team(this.team)
                 .build();
     }
 
@@ -55,7 +76,9 @@ public ExecutiveListResponseDto toListResponseDto() {
                 .id(this.id)
                 .name(this.name)
                 .position(this.position)
-                .githubUrl(this.githubUrl)
+                .role(this.role)
+                .github_username(this.githubUsername)
+                .team(this.team)
                 .build();
     }
 }
diff --git a/src/main/java/dmu/dasom/api/domain/executive/service/ExecutiveServiceImpl.java b/src/main/java/dmu/dasom/api/domain/executive/service/ExecutiveServiceImpl.java
@@ -62,7 +62,7 @@ public ExecutiveResponseDto updateExecutive(Long id, ExecutiveUpdateRequestDto r
         ExecutiveEntity executive = executiveRepository.findById(id)
                 .orElseThrow(() -> new CustomException(ErrorCode.EXECUTIVE_NOT_FOUND));
 
-        executive.update(requestDto.getName(), requestDto.getPosition(), requestDto.getGithubUrl());
+        executive.update(requestDto);
 
         return executive.toResponseDto();
     }

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public ExecutiveResponseDto updateExecutive(Long id, ExecutiveUpdateRequestDto r`
`62`	`62`	`ExecutiveEntity executive = executiveRepository.findById(id)`
`63`	`63`	`.orElseThrow(() -> new CustomException(ErrorCode.EXECUTIVE_NOT_FOUND));`
`64`	`64`
`65`		`- executive.update(requestDto.getName(), requestDto.getPosition(), requestDto.getGithubUrl());`
	`65`	`+ executive.update(requestDto);`
`66`	`66`
`67`	`67`	`return executive.toResponseDto();`
`68`	`68`	`}`