Skip to content

Commit e7a3993

Browse files
committed
refactor: News 예외처리 수정
1 parent 6c6e3f9 commit e7a3993

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/main/java/dmu/dasom/api/domain/common/exception/ErrorCode.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ public enum ErrorCode {
2323
SEND_EMAIL_FAIL(400, "C014", "이메일 전송에 실패하였습니다."),
2424
MAIL_TYPE_NOT_VALID(400, "C015", "메일 타입이 올바르지 않습니다."),
2525
INVALID_DATETIME_FORMAT(400, "C016", "날짜 형식이 올바르지 않습니다."),
26-
INVALID_TIME_FORMAT(400, "C017", "시간 형식이 올바르지 않습니다.")
27-
;
26+
INVALID_TIME_FORMAT(400, "C017", "시간 형식이 올바르지 않습니다."),
2827

2928
private final int status;
3029
private final String code;

src/main/java/dmu/dasom/api/domain/news/service/NewsService.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package dmu.dasom.api.domain.news.service;
22

3+
import dmu.dasom.api.domain.common.exception.CustomException;
4+
import dmu.dasom.api.domain.common.exception.ErrorCode;
35
import dmu.dasom.api.domain.news.dto.NewsRequestDto;
46
import dmu.dasom.api.domain.news.dto.NewsResponseDto;
57
import dmu.dasom.api.domain.news.entity.NewsEntity;
@@ -29,7 +31,7 @@ public List<NewsResponseDto> getAllNews() {
2931
public NewsResponseDto getNewsById(Long id) {
3032
return newsRepository.findById(id)
3133
.map(NewsEntity::toResponseDto)
32-
.orElseThrow(() -> new IllegalArgumentException("해당 뉴스가 존재하지 않습니다. ID: " + id));
34+
.orElseThrow(() -> new CustomException(ErrorCode.NOT_FOUND));
3335
}
3436

3537
// 생성
@@ -48,7 +50,7 @@ public NewsResponseDto createNews(NewsRequestDto requestDto) {
4850
@Transactional
4951
public NewsResponseDto updateNews(Long id, NewsRequestDto requestDto) {
5052
NewsEntity news = newsRepository.findById(id)
51-
.orElseThrow(() -> new IllegalArgumentException("해당 뉴스가 존재하지 않습니다. ID: " + id));
53+
.orElseThrow(() -> new CustomException(ErrorCode.NOT_FOUND));
5254

5355
news.update(requestDto.getTitle(), requestDto.getContent(), requestDto.getImageUrl());
5456
return news.toResponseDto();
@@ -58,8 +60,9 @@ public NewsResponseDto updateNews(Long id, NewsRequestDto requestDto) {
5860
@Transactional
5961
public void deleteNews(Long id) {
6062
NewsEntity news = newsRepository.findById(id)
61-
.orElseThrow(() -> new IllegalArgumentException("해당 뉴스가 존재하지 않습니다. ID: " + id));
63+
.orElseThrow(() -> new CustomException(ErrorCode.NOT_FOUND));
6264

6365
newsRepository.delete(news);
6466
}
67+
6568
}

0 commit comments

Comments
 (0)