feat: ExecutiveService 인터페이스 구현 및 기존 파일 이름 변경 (DASOMBE-14)

Author: si-zero

src/main/java/dmu/dasom/api/domain/executive/controller/ExecutiveController.java

@@ -4,7 +4,7 @@
 import dmu.dasom.api.domain.executive.dto.ExecutiveRequestDto;
 import dmu.dasom.api.domain.executive.dto.ExecutiveResponseDto;
 import dmu.dasom.api.domain.executive.dto.ExecutiveUpdateRequestDto;
-import dmu.dasom.api.domain.executive.service.ExecutiveService;
+import dmu.dasom.api.domain.executive.service.ExecutiveServiceImpl;
 import io.swagger.v3.oas.annotations.Operation;
 import io.swagger.v3.oas.annotations.tags.Tag;
 import jakarta.validation.Valid;
@@ -19,7 +19,7 @@
 @RequestMapping("/api/executives")
 public class ExecutiveController {
 
-    private final ExecutiveService executiveService;
+    private final ExecutiveServiceImpl executiveService;
 
     @Operation(summary = "임원진 조회")
     @GetMapping("/{id}")

src/main/java/dmu/dasom/api/domain/executive/service/ExecutiveService.java

@@ -1,55 +1,17 @@
 package dmu.dasom.api.domain.executive.service;
 
-import dmu.dasom.api.domain.common.exception.CustomException;
-import dmu.dasom.api.domain.common.exception.ErrorCode;
 import dmu.dasom.api.domain.executive.dto.ExecutiveCreationResponseDto;
 import dmu.dasom.api.domain.executive.dto.ExecutiveRequestDto;
 import dmu.dasom.api.domain.executive.dto.ExecutiveResponseDto;
 import dmu.dasom.api.domain.executive.dto.ExecutiveUpdateRequestDto;
-import dmu.dasom.api.domain.executive.entity.ExecutiveEntity;
-import dmu.dasom.api.domain.executive.repository.ExecutiveRepository;
-import lombok.RequiredArgsConstructor;
-import org.springframework.stereotype.Service;
-import org.springframework.transaction.annotation.Transactional;
 
-@Service
-@RequiredArgsConstructor
-@Transactional(readOnly = true) // 기본값 : 읽기 전용
-public class ExecutiveService {
+public interface ExecutiveService {
 
-    private final ExecutiveRepository executiveRepository;
+    ExecutiveResponseDto getExecutiveById(Long id);
 
-    // 임원진 멤버 조회
-    // 이름, 직책, 깃허브 주소 검색
-    public ExecutiveResponseDto getExecutiveById(Long id) {
-        ExecutiveEntity executive = executiveRepository.findById(id)
-                .orElseThrow(() -> new CustomException(ErrorCode.EXECUTIVE_NOT_FOUND));
+    ExecutiveCreationResponseDto createExecutive(ExecutiveRequestDto requestDto);
 
-        return executive.toResponseDto();
-    }
+    void deleteExective(Long id);
 
-    // 임원진 멤버 생성
-    public ExecutiveCreationResponseDto createExecutive(ExecutiveRequestDto requestDto) {
-        return new ExecutiveCreationResponseDto(executiveRepository.save(requestDto.toEntity()).getId());
-    }
-
-    // 임원진 멤버 삭제
-    @Transactional
-    public void deleteExective(Long id) {
-        ExecutiveEntity executive = executiveRepository.findById(id)
-                .orElseThrow(() -> new CustomException(ErrorCode.EXECUTIVE_NOT_FOUND));
-
-        executiveRepository.delete(executive);
-    }
-
-    // 임원진 멤버 수정
-    @Transactional
-    public ExecutiveResponseDto updateExecutive(Long id, ExecutiveUpdateRequestDto requestDto) {
-        ExecutiveEntity executive = executiveRepository.findById(id)
-                .orElseThrow(() -> new CustomException(ErrorCode.EXECUTIVE_NOT_FOUND));
-
-        executive.update(requestDto.getName(), requestDto.getPosition(), requestDto.getGithubUrl());
-
-        return executive.toResponseDto();
-    }
+    ExecutiveResponseDto updateExecutive(Long id, ExecutiveUpdateRequestDto requestDto);
 }

src/main/java/dmu/dasom/api/domain/executive/service/ExecutiveServiceImpl.java

@@ -0,0 +1,55 @@
+package dmu.dasom.api.domain.executive.service;
+
+import dmu.dasom.api.domain.common.exception.CustomException;
+import dmu.dasom.api.domain.common.exception.ErrorCode;
+import dmu.dasom.api.domain.executive.dto.ExecutiveCreationResponseDto;
+import dmu.dasom.api.domain.executive.dto.ExecutiveRequestDto;
+import dmu.dasom.api.domain.executive.dto.ExecutiveResponseDto;
+import dmu.dasom.api.domain.executive.dto.ExecutiveUpdateRequestDto;
+import dmu.dasom.api.domain.executive.entity.ExecutiveEntity;
+import dmu.dasom.api.domain.executive.repository.ExecutiveRepository;
+import lombok.RequiredArgsConstructor;
+import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
+
+@Service
+@RequiredArgsConstructor
+@Transactional(readOnly = true) // 기본값 : 읽기 전용
+public class ExecutiveServiceImpl implements ExecutiveService {
+
+    private final ExecutiveRepository executiveRepository;
+
+    // 임원진 멤버 조회
+    // 이름, 직책, 깃허브 주소 검색
+    public ExecutiveResponseDto getExecutiveById(Long id) {
+        ExecutiveEntity executive = executiveRepository.findById(id)
+                .orElseThrow(() -> new CustomException(ErrorCode.EXECUTIVE_NOT_FOUND));
+
+        return executive.toResponseDto();
+    }
+
+    // 임원진 멤버 생성
+    public ExecutiveCreationResponseDto createExecutive(ExecutiveRequestDto requestDto) {
+        return new ExecutiveCreationResponseDto(executiveRepository.save(requestDto.toEntity()).getId());
+    }
+
+    // 임원진 멤버 삭제
+    @Transactional
+    public void deleteExective(Long id) {
+        ExecutiveEntity executive = executiveRepository.findById(id)
+                .orElseThrow(() -> new CustomException(ErrorCode.EXECUTIVE_NOT_FOUND));
+
+        executiveRepository.delete(executive);
+    }
+
+    // 임원진 멤버 수정
+    @Transactional
+    public ExecutiveResponseDto updateExecutive(Long id, ExecutiveUpdateRequestDto requestDto) {
+        ExecutiveEntity executive = executiveRepository.findById(id)
+                .orElseThrow(() -> new CustomException(ErrorCode.EXECUTIVE_NOT_FOUND));
+
+        executive.update(requestDto.getName(), requestDto.getPosition(), requestDto.getGithubUrl());
+
+        return executive.toResponseDto();
+    }
+}

src/test/java/dmu/dasom/api/domain/executive/service/ExecutiveServiceTest.java

@@ -27,7 +27,7 @@ class ExecutiveServiceTest {
 
     // 생성자 주입
     @InjectMocks
-    private ExecutiveService executiveService;
+    private ExecutiveServiceImpl executiveService;
 
     @Test
     @DisplayName("임원진 멤버 조회 - 성공")