[feat] 메일 발송 기능 구현 #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/dmu/dasom/api/domain/applicant/repository/ApplicantRepository.java
ysw789
reviewed
Feb 18, 2025
| } | ||
|
|
||
| @Operation(summary = "지원자 메일 전송") | ||
| @Operation(summary = "서류 결과 메일 전송") |
Member
There was a problem hiding this comment.
서류, 최종 결과 메일 발송 메소드를 따로 나누지 않고 메일 발송 메소드 식으로 하나로 합쳐 클라이언트 요청에 따라 다르게 처리할 수 있을 것 같네요.
Enum으로 타입을 정의해놓고 클라이언트로부터 요청과 함께 메일 발송 타입을 전달받으면 그에 따라 발송되는 식으로 하는 건 어떨까요?
Collaborator
Author
There was a problem hiding this comment.
That is good idea!!
ysw789
reviewed
Feb 18, 2025
| // 지원자 이메일 보내기 | ||
| @Override | ||
| public void sendEmailsToApplicants(){ | ||
| public void sendDocumentPassEmailsToApplicants(){ |
Member
There was a problem hiding this comment.
AdminController 코멘트와 마찬가지로 메일 발송 메소드를 하나로 정의하고 발송 타입에 따라 다르게 동작되도록 구현하면 좋을 것 같습니다.
ysw789
reviewed
Feb 18, 2025
| case FINAL_RESULT: | ||
| applicants = applicantRepository.findByStatusIn( | ||
| List.of(ApplicantStatus.INTERVIEW_PASSED, | ||
| ApplicantStatus.INTERVIEW_PASSED) |
Member
There was a problem hiding this comment.
최종 결과 안내는 상태가 INTERVIEW_PASSED, INTERVIEW_FAILED 인 지원자에게 발송하도록 수정해주세요
ysw789
approved these changes
Feb 18, 2025
…mailServiceTest 작성
…스트용 환경변수 파일 작성 예정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[feat] 메일 발송 기능 구현
#38
변경 내용
구현 사항