now throws exception wehn duplicate CIM property

runeanielsen · runeanielsen · commit 6d885fe258dd · 2025-11-02T10:07:04.000+01:00
diff --git a/src/CIM.Mapper/DAX.IO/Readers/NetSamXMLReader.cs b/src/CIM.Mapper/DAX.IO/Readers/NetSamXMLReader.cs
@@ -624,7 +624,11 @@ private void FirstParse()
                 // End of cim property
                 else if (reader.Depth == 2 && reader.NodeType == XmlNodeType.EndElement)
                 {
-                    keyValuePairs.Add(attributeName.ToLower(), attributeValue);
+                    if (!keyValuePairs.TryAdd(attributeName.ToLower(), attributeValue))
+                    {
+                        throw new InvalidDataException(
+                            $"Duplicate CIM property: '{attributeName.ToLower()}' on line {lineNumber}.");
+                    }
                 }
                 // End of cim object
                 if (reader.Depth == 1 && reader.NodeType == XmlNodeType.EndElement)

Original file line number	Diff line number	Diff line change
`@@ -624,7 +624,11 @@ private void FirstParse()`
`624`	`624`	`// End of cim property`
`625`	`625`	`else if (reader.Depth == 2 && reader.NodeType == XmlNodeType.EndElement)`
`626`	`626`	`{`
`627`		`- keyValuePairs.Add(attributeName.ToLower(), attributeValue);`
	`627`	`+ if (!keyValuePairs.TryAdd(attributeName.ToLower(), attributeValue))`
	`628`	`+ {`
	`629`	`+ throw new InvalidDataException(`
	`630`	`+ $"Duplicate CIM property: '{attributeName.ToLower()}' on line {lineNumber}.");`
	`631`	`+ }`
`628`	`632`	`}`
`629`	`633`	`// End of cim object`
`630`	`634`	`if (reader.Depth == 1 && reader.NodeType == XmlNodeType.EndElement)`