fix: RuntimeError when trying to update deleted matrix element (close #38)

Author: paulmueller

CHANGELOG

@@ -1,6 +1,8 @@
 2.0.2
  - fix: IndexError when removing a plot (#36)
- - fix: ValueError wehn filtering all events in Quick View (#37)
+ - fix: ValueError when filtering all events in Quick View (#37)
+ - fix: TypeError when removing datasets and opening Quick View (#38)
+ - fix: RuntimeError when removing datasets and opening Quick View (#38)
 2.0.1
  - fix: correctly distinguish prereleases when checking for new versions
  - enh: allow loading data via drag&drop

shapeout2/gui/matrix/dm_element.py

@@ -87,7 +87,11 @@ def update_content(self, quickview=False):
                 # reset color of old quick view instance
                 if curinst is not None and self is not curinst:
                     MatrixElement._quick_view_instance = None
-                    curinst.update_content()
+                    try:
+                        curinst.update_content()
+                    except RuntimeError:
+                        # element has been deleted
+                        pass
                 MatrixElement._quick_view_instance = self
                 do_quickview = True
             else:

tests/test_gui_quickview.py

@@ -50,6 +50,59 @@ def test_clear_session_issue_25(qtbot):
     mw.on_action_clear(assume_yes=True)
 
 
+def test_no_events_issue_37(qtbot):
+    """https://github.com/ZELLMECHANIK-DRESDEN/ShapeOut2/issues/37
+
+    "ValueError: zero-size array to reduction operation minimum
+    which has no identity" when all events are filtered out.
+    """
+    mw = ShapeOut2()
+    qtbot.addWidget(mw)
+
+    # add a dataslot
+    path = pathlib.Path(__file__).parent / "data" / "calibration_beads_47.rtdc"
+    mw.add_dataslot(paths=[path, path])
+
+    assert len(mw.pipeline.slot_ids) == 2, "we added those"
+    assert len(mw.pipeline.filter_ids) == 1, "automatically added"
+
+    # activate a dataslot
+    slot_id = mw.pipeline.slot_ids[0]
+    filt_id = mw.pipeline.filter_ids[0]
+    em = mw.block_matrix.get_widget(slot_id, filt_id)
+    qtbot.mouseClick(em, QtCore.Qt.LeftButton)  # activate
+    # did that work?
+    assert mw.pipeline.is_element_active(slot_id, filt_id)
+
+    # filter away all events
+    fe = mw.block_matrix.get_widget(filt_plot_id=filt_id)
+    qtbot.mouseClick(fe.toolButton_modify, QtCore.Qt.LeftButton)
+    fv = mw.widget_ana_view.widget_filter
+    qtbot.mouseClick(fv.toolButton_moreless, QtCore.Qt.LeftButton)
+    rc = fv._box_range_controls["area_um"]
+    qtbot.mouseClick(rc.checkBox, QtCore.Qt.LeftButton)
+    # did that work?
+    assert rc.checkBox.isChecked()
+    qtbot.mouseClick(fv.toolButton_moreless, QtCore.Qt.LeftButton)
+    # set range
+    rc.doubleSpinBox_min.setValue(0)
+    rc.doubleSpinBox_max.setValue(1)
+    qtbot.mouseClick(fv.pushButton_apply, QtCore.Qt.LeftButton)
+    # did that work?
+    ds = mw.pipeline.get_dataset(slot_index=0, filt_index=0,
+                                 apply_filter=True)
+    assert np.sum(ds.filter.all) == 0
+
+    # open QuickView
+    slot_id = mw.pipeline.slot_ids[0]
+    filt_id = mw.pipeline.filter_ids[0]
+    em = mw.block_matrix.get_widget(slot_id, filt_id)
+
+    # this raised the error
+    qtbot.mouseClick(em, QtCore.Qt.LeftButton, QtCore.Qt.ShiftModifier)
+    mw.close()
+
+
 def test_update_polygon_filter_issue_26(qtbot):
     """https://github.com/ZELLMECHANIK-DRESDEN/ShapeOut2/issues/26