Skip to content

Commit d19ed33

Browse files
dcgclaude
authored andcommitted
fix(dash-spv): remove obsolete StoredTerminalBlock references from tests
The StoredTerminalBlock type and related methods (store_terminal_block, get_terminal_block, clear_terminal_block) were removed from the StorageManager trait but references remained in test mock implementations. - Removed terminal block method implementations from MockStorageManager in error_handling_test.rs and error_recovery_integration_test.rs - These methods are no longer part of the StorageManager trait Note: These test files still have other compilation issues with their mock implementations that need separate fixes. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 5cc8429 commit d19ed33

File tree

2 files changed

+4
-41
lines changed

2 files changed

+4
-41
lines changed

dash-spv/tests/error_handling_test.rs

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -378,31 +378,8 @@ impl StorageManager for MockStorageManager {
378378
Ok(None)
379379
}
380380

381-
async fn store_terminal_block(
382-
&mut self,
383-
_block: &dash_spv::storage::StoredTerminalBlock,
384-
) -> StorageResult<()> {
385-
if self.fail_on_write {
386-
return Err(StorageError::WriteFailed("Mock write failure".to_string()));
387-
}
388-
Ok(())
389-
}
390-
391-
async fn get_terminal_block(
392-
&self,
393-
) -> StorageResult<Option<dash_spv::storage::StoredTerminalBlock>> {
394-
if self.fail_on_read {
395-
return Err(StorageError::ReadFailed("Mock read failure".to_string()));
396-
}
397-
Ok(None)
398-
}
399-
400-
async fn clear_terminal_block(&mut self) -> StorageResult<()> {
401-
if self.fail_on_write {
402-
return Err(StorageError::WriteFailed("Mock write failure".to_string()));
403-
}
404-
Ok(())
405-
}
381+
// Terminal block methods removed from StorageManager trait
382+
// These methods are no longer part of the trait
406383
}
407384

408385
// ===== Network Error Tests =====

dash-spv/tests/error_recovery_integration_test.rs

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -650,20 +650,6 @@ impl StorageManager for MockStorageManager {
650650
Ok(None)
651651
}
652652

653-
async fn store_terminal_block(
654-
&mut self,
655-
_block: &dash_spv::storage::StoredTerminalBlock,
656-
) -> dash_spv::error::StorageResult<()> {
657-
Ok(())
658-
}
659-
660-
async fn get_terminal_block(
661-
&self,
662-
) -> dash_spv::error::StorageResult<Option<dash_spv::storage::StoredTerminalBlock>> {
663-
Ok(None)
664-
}
665-
666-
async fn clear_terminal_block(&mut self) -> dash_spv::error::StorageResult<()> {
667-
Ok(())
668-
}
653+
// Terminal block methods removed from StorageManager trait
654+
// These methods are no longer part of the trait
669655
}

0 commit comments

Comments
 (0)