Skip to content

Commit 6e258c5

Browse files
DanBlackwellDebadri Basak
authored andcommitted
[TSan][Test-Only][Darwin] Fix typo in external.cpp test (llvm#165534)
Occasionally this test fails in CI. There are two possible races that can occur, one of which is rare. Both are supposed to be handled, but because the test matches "read-only" and the runtime outputs "Read-only" (note the capital letter), the FileCheck fails. This patch fixes the miscapitalisation of the FileCheck string in the test. rdar://163398219
1 parent e8c49dd commit 6e258c5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

compiler-rt/test/tsan/Darwin/external.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@ int main(int argc, char *argv[]) {
6868
// TEST2-NOT: WARNING: ThreadSanitizer
6969

7070
// TEST3: WARNING: ThreadSanitizer: race on MyLibrary::MyObject
71-
// TEST3: {{Modifying|read-only}} access of MyLibrary::MyObject at
71+
// TEST3: {{Modifying|Read-only}} access of MyLibrary::MyObject at
7272
// TEST3: {{ObjectWrite|ObjectRead}}
73-
// TEST3: Previous {{modifying|read-only}} access of MyLibrary::MyObject at
73+
// TEST3: Previous {{modifying|Read-only}} access of MyLibrary::MyObject at
7474
// TEST3: {{ObjectWrite|ObjectRead}}
7575
// TEST3: Location is MyLibrary::MyObject of size 16 at
7676
// TEST3: {{ObjectCreate}}

0 commit comments

Comments
 (0)