Skip to content

Commit ec85f4e

Browse files
kuharDebadri Basak
authored andcommitted
[ADT] Deprecate variadic StringSwitch::CasesLower. NFC. (llvm#166016)
Suggest the initializer_list overload instead. I plan to deprecate the last variadic `.Cases` in a separate PR. For more context, see llvm#163117.
1 parent d81a545 commit ec85f4e

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

clang/lib/CIR/CodeGen/CIRGenOpenACCClause.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ class OpenACCClauseCIREmitter final
126126
.CaseLower("default", mlir::acc::DeviceType::Default)
127127
.CaseLower("host", mlir::acc::DeviceType::Host)
128128
.CaseLower("multicore", mlir::acc::DeviceType::Multicore)
129-
.CasesLower("nvidia", "acc_device_nvidia",
129+
.CasesLower({"nvidia", "acc_device_nvidia"},
130130
mlir::acc::DeviceType::Nvidia)
131131
.CaseLower("radeon", mlir::acc::DeviceType::Radeon);
132132
}

llvm/include/llvm/ADT/StringSwitch.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ class StringSwitch {
173173
return CasesLowerImpl(CaseStrings, Value);
174174
}
175175

176+
[[deprecated("Pass cases in std::initializer_list instead")]]
176177
StringSwitch &CasesLower(StringLiteral S0, StringLiteral S1, T Value) {
177178
return CasesLowerImpl({S0, S1}, Value);
178179
}

llvm/lib/MC/MCParser/MasmParser.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5323,10 +5323,10 @@ void MasmParser::initializeDirectiveKindMap() {
53235323
bool MasmParser::isMacroLikeDirective() {
53245324
if (getLexer().is(AsmToken::Identifier)) {
53255325
bool IsMacroLike = StringSwitch<bool>(getTok().getIdentifier())
5326-
.CasesLower("repeat", "rept", true)
5326+
.CasesLower({"repeat", "rept"}, true)
53275327
.CaseLower("while", true)
5328-
.CasesLower("for", "irp", true)
5329-
.CasesLower("forc", "irpc", true)
5328+
.CasesLower({"for", "irp"}, true)
5329+
.CasesLower({"forc", "irpc"}, true)
53305330
.Default(false);
53315331
if (IsMacroLike)
53325332
return true;

0 commit comments

Comments
 (0)