Skip to content

Commit dcdd3cf

Browse files
fix/DF-531: Error stack traces (#1114)
* Add explicit dependency to hapi/hoek to force version 11.0.7 * Tidy up generic onPreResponse error logging
1 parent 81da6af commit dcdd3cf

File tree

3 files changed

+60
-180
lines changed

3 files changed

+60
-180
lines changed

designer/server/src/plugins/errorPage.ts

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import Boom from '@hapi/boom'
12
import {
23
type Request,
34
type ResponseToolkit,
@@ -24,11 +25,10 @@ export default {
2425
server.ext('onPreResponse', (request: Request, h: ResponseToolkit) => {
2526
const response = request.response
2627

27-
if ('isBoom' in response && response.isBoom) {
28+
if (Boom.isBoom(response)) {
2829
// An error was raised during
2930
// processing the request
3031
const statusCode = response.output.statusCode
31-
const errorMessage = errorCodes.get(statusCode)
3232

3333
if (statusCode === StatusCodes.NOT_FOUND.valueOf()) {
3434
request.logger.info(
@@ -40,21 +40,17 @@ export default {
4040
.code(statusCode)
4141
}
4242

43-
const logLevel =
44-
statusCode === StatusCodes.NOT_FOUND.valueOf() ? 'info' : 'error'
45-
request.logger[logLevel](
46-
response,
47-
statusCode === StatusCodes.NOT_FOUND.valueOf()
48-
? 'Resource not found'
49-
: 'Unhandled error found'
50-
)
43+
request.logger.error(response, 'Unhandled error found')
44+
45+
const errorMessage = errorCodes.get(statusCode)
5146

5247
if (errorMessage) {
5348
return h
5449
.view(statusCode.toString(), errorViewModel(errorMessage))
5550
.code(statusCode)
5651
}
5752
}
53+
5854
return h.continue
5955
})
6056
}

0 commit comments

Comments
 (0)