Sonar qube issues #3

Author: kristan66

src/KeeperData.Core.Reports/Impl/CleanseReportExportService.cs

@@ -48,12 +48,12 @@ public async Task<CleanseReportExportResult> ExportAndUploadAsync(string operati
                 operationId, timestamp);
 
             // Step 1: Stream issues from MongoDB directly to CSV file
-            tempCsvPath = Path.GetTempFileName();
+            tempCsvPath = Path.GetRandomFileName();
             var recordCount = await StreamIssuesToCsvAsync(tempCsvPath, ct);
             _logger.LogInformation("Streamed {RecordCount} issues to CSV file at {TempPath}", recordCount, tempCsvPath);
 
             // Step 2: Create zip file
-            tempZipPath = Path.GetTempFileName();
+            tempZipPath = Path.GetRandomFileName();
             CreateZipFile(tempCsvPath, tempZipPath, CsvFileName);
             _logger.LogInformation("Created zip file at {ZipPath}", tempZipPath);
 

src/KeeperData.Core.Reports/Strategies/DataFields.cs

@@ -25,7 +25,6 @@ public static class SamHerd
         public const string Herdmark = "HERDMARK";
         public const string Intervals = "INTERVALS";
         public const string IntervalUnitOfTime = "INTERVAL_UNIT_OF_TIME";
-        public const string IsDeleted = "IsDeleted";
         public const string KeeperPartyIds = "KEEPER_PARTY_IDS";
         public const string MovementRestrictionReasonCode = "MOVEMENT_RSTRCTN_RSN_CODE";
         public const string OwnerPartyIds = "OWNER_PARTY_IDS";
@@ -43,7 +42,6 @@ public static class CtsCphHoldingFields
         public const string BatchId = "BATCH_ID";
         public const string ChangeType = "CHANGE_TYPE";
         public const string CreatedAtUtc = "CreatedAtUtc";
-        public const string IsDeleted = "IsDeleted";
         public const string LidFullIdentifier = "LID_FULL_IDENTIFIER";
         public const string LocEffectiveFrom = "LOC_EFFECTIVE_FROM";
         public const string LocEffectiveTo = "LOC_EFFECTIVE_TO";
@@ -65,7 +63,6 @@ public static class CtsKeeperFields
         public const string BatchId = "BATCH_ID";
         public const string ChangeType = "CHANGE_TYPE";
         public const string CreatedAtUtc = "CreatedAtUtc";
-        public const string IsDeleted = "IsDeleted";
         public const string LidFullIdentifier = "LID_FULL_IDENTIFIER";
         public const string LprEffectiveFromDate = "LPR_EFFECTIVE_FROM_DATE";
         public const string LprEffectiveToDate = "LPR_EFFECTIVE_TO_DATE";
@@ -86,7 +83,6 @@ public static class SamPartyFields
         public const string CountryCode = "COUNTRY_CODE";
         public const string CreatedAtUtc = "CreatedAtUtc";
         public const string InternetEmailAddress = "INTERNET_EMAIL_ADDRESS";
-        public const string IsDeleted = "IsDeleted";
         public const string Locality = "LOCALITY";
         public const string MobileNumber = "MOBILE_NUMBER";
         public const string OrganisationName = "ORGANISATION_NAME";
@@ -142,7 +138,6 @@ public static class SamCphHoldingFields
         public const string FeatureStatusCode = "FEATURE_STATUS_CODE";
         public const string Interval = "INTERVAL";
         public const string IntervalUnitOfTime = "INTERVAL_UNIT_OF_TIME";
-        public const string IsDeleted = "IsDeleted";
         public const string Locality = "LOCALITY";
         public const string MovementRestrictionReasonCode = "MOVEMENT_RSTRCTN_RSN_CODE";
         public const string Northing = "NORTHING";

src/KeeperData.Core/Querying/Impl/ODataToFilterExpressionTranslator.cs

@@ -12,7 +12,6 @@ namespace KeeperData.Core.Querying.Impl;
 internal class ODataToFilterExpressionTranslator
 {
     private readonly IEdmModel _model;
-    private readonly IEdmEntityType _entityType;
 
     public ODataToFilterExpressionTranslator()
     {
@@ -25,7 +24,6 @@ public ODataToFilterExpressionTranslator()
         model.AddElement(container);
 
         _model = model;
-        _entityType = entityType;
     }
 
     public FilterExpression Parse(string filterExpression)

tests/KeeperData.Core.Tests.Unit/Crypto/ByteCountingStreamTests.cs

@@ -238,7 +238,8 @@ public void Flush_FlushesInnerStream()
         sut.Write(new byte[] { 1, 2, 3 }, 0, 3);
 
         // Act & Assert - should not throw
-        sut.Flush();
+        var act = () => sut.Flush();
+        act.Should().NotThrow();
     }
 
     [Fact]
@@ -250,7 +251,8 @@ public async Task FlushAsync_FlushesInnerStream()
         await sut.WriteAsync(new byte[] { 1, 2, 3 }, 0, 3);
 
         // Act & Assert - should not throw
-        await sut.FlushAsync();
+        var act = () => sut.FlushAsync();
+        await act.Should().NotThrowAsync();
     }
 
     [Fact]