Remove duplicate function for compatible states check

Author: taburg

aalpy/learning_algs/deterministic_passive/ClassicRPNI.py

@@ -27,7 +27,7 @@ def run_rpni(self):
             merged = False
 
             for red_state in red:
-                if not self._compatible_states(red_state, lex_min_blue):
+                if not red_state.compatible_outputs(lex_min_blue):
                     continue
                 merge_candidate = self._merge(red_state, lex_min_blue, copy_nodes=True)
                 if self._compatible(merge_candidate):
@@ -62,20 +62,6 @@ def _compatible(self, root_node):
                 return False
         return True
 
-    # TODO this function is a duplicate
-    def _compatible_states(self, red_node, blue_node):
-        """
-        Only allow merging of states that have same output(s).
-        """
-        if self.automaton_type != 'mealy':
-            # None is compatible with everything
-            return red_node.output == blue_node.output or red_node.output is None or blue_node.output is None
-        else:
-            for common_i in set(red_node.output.keys()).intersection(blue_node.output.keys()):
-                if red_node.output[common_i] != blue_node.output[common_i]:
-                    return False
-        return True
-
     def _merge(self, red_node, lex_min_blue, copy_nodes=False):
         """
         Merge two states and return the root node of resulting model.

aalpy/learning_algs/deterministic_passive/rpni_helper_functions.py

@@ -34,6 +34,9 @@ def __hash__(self):
         return id(self)  # TODO This is a hack
 
     def compatible_outputs(self, other):
+        """
+        Only allow merging of states that have same output(s).
+        """
         # None is compatible with everything
         if self.type != 'mealy':
             return self.output == other.output or self.output is None or other.output is None