ci.yml typo fixed

Author: DEVMANISHOFFL

.github/workflows/ci.yml

@@ -62,6 +62,11 @@ jobs:
           exit 1
 
       - name: Run Full E2E Checkout Flow
+        env:
+          E2E_PRODUCT_ID: 92390a37-43f7-404c-979d-1614afc7309b
+          E2E_VARIANT_ID: b1db6569-6ad7-48d3-8c88-5a29bb05445d
+          E2E_SESSION_ID: e2e-ci-session
+          INTERNAL_SERVICE_KEY: sabhyatam-internal-2025
         run: |
           go run ./tools/e2e_checkout
 

tools/e2e_checkout/cart.go

@@ -5,42 +5,32 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
-	"time"
 )
 
-func addToCart(productID, variantID, sessionID string) {
+func addToCart() {
 	body := map[string]any{
-		"product_id": productID,
-		"variant_id": variantID,
+		"product_id": e2eProductID,
+		"variant_id": e2eVariantID,
 		"quantity":   1,
 	}
 
 	b, _ := json.Marshal(body)
 
-	var lastErr error
-
-	for i := 1; i <= 10; i++ {
-		req, _ := http.NewRequest(
-			"POST",
-			cartBase+"/v1/cart/add",
-			bytes.NewReader(b),
-		)
-		req.Header.Set("Content-Type", "application/json")
-		req.Header.Set("X-SESSION-ID", sessionID)
-
-		resp, err := http.DefaultClient.Do(req)
-		if err != nil {
-			lastErr = err
-		} else {
-			resp.Body.Close()
-			if resp.StatusCode == http.StatusOK || resp.StatusCode == http.StatusCreated {
-				return // ✅ success
-			}
-			lastErr = fmt.Errorf("status %d", resp.StatusCode)
-		}
-
-		time.Sleep(2 * time.Second)
+	req, _ := http.NewRequest(
+		http.MethodPost,
+		cartBase+"/v1/cart/add",
+		bytes.NewReader(b),
+	)
+	req.Header.Set("Content-Type", "application/json")
+	req.Header.Set("X-SESSION-ID", e2eSessionID)
+
+	resp, err := http.DefaultClient.Do(req)
+	if err != nil {
+		panic(err)
 	}
+	defer resp.Body.Close()
 
-	panic(fmt.Errorf("addToCart failed after retries: %v", lastErr))
+	if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusCreated {
+		panic(fmt.Errorf("addToCart failed: %d", resp.StatusCode))
+	}
 }

tools/e2e_checkout/config.go

@@ -1,16 +1,31 @@
 package main
 
-const (
-	productBase  = "http://localhost:8080"
-	cartBase     = "http://localhost:8081"
-	ordersBase   = "http://localhost:8082"
-	paymentsBase = "http://localhost:8083"
+import "os"
 
-	internalKey = "sabhyatam-internal-2025"
+var (
+	productBase  = getenv("PRODUCT_BASE", "http://localhost:8080")
+	cartBase     = getenv("CART_BASE", "http://localhost:8081")
+	ordersBase   = getenv("ORDERS_BASE", "http://localhost:8082")
+	paymentsBase = getenv("PAYMENTS_BASE", "http://localhost:8083")
 
-	// change only this
-	testProductID = "99d56444-6e73-4ce1-aee1-e718331b0e1f"
-	testVariantID = "1d7d7b72-92f6-4451-af54-844454979b02"
+	internalKey = getenv("INTERNAL_SERVICE_KEY", "sabhyatam-internal-2025")
 
-	sessionID = "e2e_guest_001"
+	e2eProductID = mustEnv("E2E_PRODUCT_ID")
+	e2eVariantID = mustEnv("E2E_VARIANT_ID")
+	e2eSessionID = getenv("E2E_SESSION_ID", "e2e-session-001")
 )
+
+func getenv(k, d string) string {
+	if v := os.Getenv(k); v != "" {
+		return v
+	}
+	return d
+}
+
+func mustEnv(k string) string {
+	v := os.Getenv(k)
+	if v == "" {
+		panic("missing required env: " + k)
+	}
+	return v
+}

tools/e2e_checkout/flow_full.go

@@ -5,9 +5,9 @@ import "log"
 func runFullFlow() {
 	log.Println("🚀 Starting E2E Checkout Flow")
 
-	addToCart(testProductID, testVariantID, sessionID)
+	addToCart()
 
-	orderID := prepareOrder(sessionID)
+	orderID := prepareOrder()
 	log.Println("🧾 Order ID:", orderID)
 
 	initiatePayment(orderID)

tools/e2e_checkout/main.go

@@ -1,8 +1,5 @@
 package main
 
-import "log"
-
 func main() {
-	log.Println("🚀 Starting E2E Checkout Flow")
 	runFullFlow()
 }

tools/e2e_checkout/order.go

@@ -1,23 +1,20 @@
 package main
 
 import (
+	"bytes"
 	"encoding/json"
 	"fmt"
 	"net/http"
 )
 
-func prepareOrder(sessionID string) string {
-	req, err := http.NewRequest(
-		"POST",
+func prepareOrder() string {
+	req, _ := http.NewRequest(
+		http.MethodPost,
 		ordersBase+"/v1/orders/prepare",
-		nil,
+		bytes.NewReader([]byte(`{}`)),
 	)
-	if err != nil {
-		panic(err)
-	}
-
 	req.Header.Set("Content-Type", "application/json")
-	req.Header.Set("X-SESSION-ID", sessionID)
+	req.Header.Set("X-SESSION-ID", e2eSessionID)
 
 	resp, err := http.DefaultClient.Do(req)
 	if err != nil {
@@ -32,9 +29,7 @@ func prepareOrder(sessionID string) string {
 	var out struct {
 		OrderID string `json:"order_id"`
 	}
-	if err := json.NewDecoder(resp.Body).Decode(&out); err != nil {
-		panic(err)
-	}
+	json.NewDecoder(resp.Body).Decode(&out)
 
 	return out.OrderID
 }

tools/e2e_checkout/payment.go

@@ -20,7 +20,7 @@ func initiatePayment(orderID string) {
 	}
 	defer resp.Body.Close()
 
-	if resp.StatusCode != http.StatusOK {
+	if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusCreated {
 		panic(fmt.Errorf("initiatePayment failed: %d", resp.StatusCode))
 	}
 }