Relations do not infer the type correctly when using without ()

[haringsrob]

Cannot seem to figure out why. This should have type Tournament|null.

The method is properly typed as you can see, there is also a vendor/_laravel_ide/_model_helpers.php file, but that does not seem to be used.

[haringsrob]

After applying laravel/vs-code-extension#335 to get my subfolder indexed. It picks up the type.

But it takes the wrong priority.

[haringsrob]

I also need to add "php.workspace.includePath": "/Volumes/Sites/PROJECT/packages/backend/vendor/_laravel_ide", to get the above to work..

My workspace is a monorepo at /Volumes/Sites/PROJECT/

[jakubmisek]

Thank you for sharing the issue with us, and for the details.

Relationship methods are handled so no ide-helpers nor _laravel_ide is usually needed - we don't handle this case.

• relationship method typed with HasOne<TResult, TGroup> will be handled.
• Volumes/Sites/PROJECT/packages/backend/vendor/_laravel_ide should get indexed - is it included in your workspace? Isn't the indexing still pending? How many files is there in the workspace?

[haringsrob]

The workspace is a rather large mono-repo. (3 front-ends and one php backend). I will retry a bit later by removing it again and giving it some more time.

[jakubmisek]

Thank you @haringsrob,

The output from OUTPUT -> PHP Language Server may help (it will show how many composer.json files are there, and where), and also how much time does it take to index it

[haringsrob]

just to be sure, by relationship method typed with HasOne<TResult, TGroup> will be handled. you mean it's not yet something implemented correct? Might need to check various relations in that case.

[jakubmisek]

@haringsrob we added support for relationship methods, so code completion automatically listed the corresponding property ($tournament), BUT

• we did not expect HasOne with two generic type parameters,
• and we incorrectly used the type HasOne as the property's type instead of just being quiet

This will be fixed

If you have more examples of real-world relation methods - I'll be happy to see them and add tests for it

[jakubmisek]

Implemented in pre-release.

Full release will be out soon.