Add more analyzers and complete editorconfig

Author: gunndabad

.editorconfig

@@ -2,15 +2,254 @@
 root = true
 
 [*]
-charset = utf-8
-insert_final_newline = true
-indent_style = space
 indent_size = 2
+indent_style = space
+charset = utf-8
 trim_trailing_whitespace = true
+insert_final_newline = true
 
 [*.cs]
 indent_size = 4
-dotnet_diagnostic.IDE0005.severity = error
+tab_width = 4
+
+# Diagnostics
+dotnet_analyzer_diagnostic.category-Style.severity = warning
+dotnet_diagnostic.CA1032.severity = none
+dotnet_diagnostic.CA1822.severity = none
+dotnet_diagnostic.CA2007.severity = none
+dotnet_diagnostic.CA2227.severity = none
+dotnet_diagnostic.IDE0005.severity = warning
+dotnet_diagnostic.IDE0008.severity = none
+dotnet_diagnostic.IDE0022.severity = none
+dotnet_diagnostic.IDE0061.severity = none
+dotnet_diagnostic.IDE0058.severity = none
+
+# Organize usings
+dotnet_separate_import_directive_groups = false
 dotnet_sort_system_directives_first = true
+file_header_template = unset
+
+# this. and Me. preferences
+dotnet_style_qualification_for_event = false
+dotnet_style_qualification_for_field = false
+dotnet_style_qualification_for_method = false
+dotnet_style_qualification_for_property = false
+
+# Language keywords vs BCL types preferences
+dotnet_style_predefined_type_for_locals_parameters_members = true
+dotnet_style_predefined_type_for_member_access = true
+
+# Parentheses preferences
+dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity
+dotnet_style_parentheses_in_other_binary_operators = always_for_clarity
+dotnet_style_parentheses_in_other_operators = never_if_unnecessary
+dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity
+
+# Modifier preferences
+dotnet_style_require_accessibility_modifiers = for_non_interface_members
+
+# Expression-level preferences
+dotnet_style_coalesce_expression = true
+dotnet_style_collection_initializer = true
+dotnet_style_explicit_tuple_names = true
+dotnet_style_namespace_match_folder = true
+dotnet_style_null_propagation = true
+dotnet_style_object_initializer = true
+dotnet_style_operator_placement_when_wrapping = beginning_of_line
+dotnet_style_prefer_auto_properties = true
+dotnet_style_prefer_collection_expression = when_types_loosely_match
+dotnet_style_prefer_compound_assignment = true
+dotnet_style_prefer_conditional_expression_over_assignment = true
+dotnet_style_prefer_conditional_expression_over_return = true
+dotnet_style_prefer_foreach_explicit_cast_in_source = when_strongly_typed
+dotnet_style_prefer_inferred_anonymous_type_member_names = true
+dotnet_style_prefer_inferred_tuple_names = true
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true
+dotnet_style_prefer_simplified_boolean_expressions = true
+dotnet_style_prefer_simplified_interpolation = true
+
+# Field preferences
+dotnet_style_readonly_field = true
+
+# Parameter preferences
+dotnet_code_quality_unused_parameters = all:silent
+
+# Suppression preferences
+dotnet_remove_unnecessary_suppression_exclusions = none
+
+# New line preferences
+dotnet_style_allow_multiple_blank_lines_experimental = true
+dotnet_style_allow_statement_immediately_after_block_experimental = true
+
+#### C# Coding Conventions ####
+
+# var preferences
+csharp_style_var_elsewhere = false
+csharp_style_var_for_built_in_types = false
+csharp_style_var_when_type_is_apparent = false
+
+# Expression-bodied members
+csharp_style_expression_bodied_accessors = true
+csharp_style_expression_bodied_constructors = false
+csharp_style_expression_bodied_indexers = true
+csharp_style_expression_bodied_lambdas = true
+csharp_style_expression_bodied_local_functions = false
+csharp_style_expression_bodied_methods = false
+csharp_style_expression_bodied_operators = false
+csharp_style_expression_bodied_properties = true
+
+# Pattern matching preferences
+csharp_style_pattern_matching_over_as_with_null_check = true
+csharp_style_pattern_matching_over_is_with_cast_check = true
+csharp_style_prefer_extended_property_pattern = true
+csharp_style_prefer_not_pattern = true
+csharp_style_prefer_pattern_matching = true
+csharp_style_prefer_switch_expression = true
+
+# Null-checking preferences
+csharp_style_conditional_delegate_call = true
+
+# Modifier preferences
+csharp_prefer_static_local_function = true
+csharp_preferred_modifier_order = public,private,protected,internal,file,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,required,volatile,async
+csharp_style_prefer_readonly_struct = true
+csharp_style_prefer_readonly_struct_member = true
+
+# Code-block preferences
+csharp_prefer_braces = true
+csharp_prefer_simple_using_statement = true
 csharp_style_namespace_declarations = file_scoped:warning
-csharp_prefer_braces = true:warning
+csharp_style_prefer_method_group_conversion = true
+csharp_style_prefer_primary_constructors = true
+csharp_style_prefer_top_level_statements = true
+
+# Expression-level preferences
+csharp_prefer_simple_default_expression = true
+csharp_style_deconstructed_variable_declaration = true
+csharp_style_implicit_object_creation_when_type_is_apparent = true
+csharp_style_inlined_variable_declaration = true
+csharp_style_prefer_index_operator = true
+csharp_style_prefer_local_over_anonymous_function = true
+csharp_style_prefer_null_check_over_type_check = true
+csharp_style_prefer_range_operator = true
+csharp_style_prefer_tuple_swap = true
+csharp_style_prefer_utf8_string_literals = true
+csharp_style_throw_expression = true
+csharp_style_unused_value_assignment_preference = discard_variable
+csharp_style_unused_value_expression_statement_preference = discard_variable
+
+# 'using' directive preferences
+csharp_using_directive_placement = outside_namespace
+
+# New line preferences
+csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = true
+csharp_style_allow_blank_line_after_token_in_arrow_expression_clause_experimental = true
+csharp_style_allow_blank_line_after_token_in_conditional_expression_experimental = true
+csharp_style_allow_blank_lines_between_consecutive_braces_experimental = true
+csharp_style_allow_embedded_statements_on_same_line_experimental = true
+
+#### C# Formatting Rules ####
+
+# New line preferences
+csharp_new_line_before_catch = true
+csharp_new_line_before_else = true
+csharp_new_line_before_finally = true
+csharp_new_line_before_members_in_anonymous_types = true
+csharp_new_line_before_members_in_object_initializers = true
+csharp_new_line_before_open_brace = all
+csharp_new_line_between_query_expression_clauses = true
+
+# Indentation preferences
+csharp_indent_block_contents = true
+csharp_indent_braces = false
+csharp_indent_case_contents = true
+csharp_indent_case_contents_when_block = true
+csharp_indent_labels = one_less_than_current
+csharp_indent_switch_labels = true
+
+# Space preferences
+csharp_space_after_cast = false
+csharp_space_after_colon_in_inheritance_clause = true
+csharp_space_after_comma = true
+csharp_space_after_dot = false
+csharp_space_after_keywords_in_control_flow_statements = true
+csharp_space_after_semicolon_in_for_statement = true
+csharp_space_around_binary_operators = before_and_after
+csharp_space_around_declaration_statements = false
+csharp_space_before_colon_in_inheritance_clause = true
+csharp_space_before_comma = false
+csharp_space_before_dot = false
+csharp_space_before_open_square_brackets = false
+csharp_space_before_semicolon_in_for_statement = false
+csharp_space_between_empty_square_brackets = false
+csharp_space_between_method_call_empty_parameter_list_parentheses = false
+csharp_space_between_method_call_name_and_opening_parenthesis = false
+csharp_space_between_method_call_parameter_list_parentheses = false
+csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
+csharp_space_between_method_declaration_name_and_open_parenthesis = false
+csharp_space_between_method_declaration_parameter_list_parentheses = false
+csharp_space_between_parentheses = false
+csharp_space_between_square_brackets = false
+
+# Wrapping preferences
+csharp_preserve_single_line_blocks = true
+csharp_preserve_single_line_statements = true
+
+#### Naming styles ####
+
+# Naming rules
+
+dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
+dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
+dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
+
+dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.types_should_be_pascal_case.symbols = types
+dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
+
+dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
+dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
+
+dotnet_naming_rule.const_fields.symbols = const_fields
+dotnet_naming_rule.const_fields.style = pascal_case
+dotnet_naming_rule.const_fields.severity = suggestion
+
+dotnet_naming_rule.private_members_with_underscore.symbols = private_fields
+dotnet_naming_rule.private_members_with_underscore.style = prefix_underscore
+dotnet_naming_rule.private_members_with_underscore.severity = suggestion
+
+# Symbol specifications
+
+dotnet_naming_symbols.interface.applicable_kinds = interface
+dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.interface.required_modifiers =
+
+dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
+dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.types.required_modifiers =
+
+dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
+dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.non_field_members.required_modifiers =
+
+dotnet_naming_symbols.private_fields.applicable_kinds = field
+dotnet_naming_symbols.private_fields.applicable_accessibilities = private
+
+dotnet_naming_symbols.const_fields.applicable_kinds = field
+dotnet_naming_symbols.const_fields.required_modifiers = const
+
+# Naming styles
+
+dotnet_naming_style.pascal_case.required_prefix =
+dotnet_naming_style.pascal_case.required_suffix =
+dotnet_naming_style.pascal_case.word_separator =
+dotnet_naming_style.pascal_case.capitalization = pascal_case
+
+dotnet_naming_style.begins_with_i.required_prefix = I
+dotnet_naming_style.begins_with_i.required_suffix =
+dotnet_naming_style.begins_with_i.word_separator =
+dotnet_naming_style.begins_with_i.capitalization = pascal_case
+
+dotnet_naming_style.prefix_underscore.capitalization = camel_case
+dotnet_naming_style.prefix_underscore.required_prefix = _

src/Dfe.Analytics/AspNetCore/DfeAnalyticsAspNetCoreConfigureOptions.cs

@@ -3,14 +3,11 @@
 
 namespace Dfe.Analytics.AspNetCore;
 
-internal class DfeAnalyticsAspNetCoreConfigureOptions : IConfigureOptions<DfeAnalyticsAspNetCoreOptions>
+#pragma warning disable CA1812
+internal class DfeAnalyticsAspNetCoreConfigureOptions(IConfiguration configuration) : IConfigureOptions<DfeAnalyticsAspNetCoreOptions>
+#pragma warning restore CA1812
 {
-    private readonly IConfiguration _configuration;
-
-    public DfeAnalyticsAspNetCoreConfigureOptions(IConfiguration configuration)
-    {
-        _configuration = configuration;
-    }
+    private readonly IConfiguration _configuration = configuration;
 
     public void Configure(DfeAnalyticsAspNetCoreOptions options)
     {

src/Dfe.Analytics/AspNetCore/DfeAnalyticsAspNetCoreOptions.cs

@@ -45,7 +45,7 @@ public class DfeAnalyticsAspNetCoreOptions
     /// Whether the original response status code should be used for requests that have been reexecuted
     /// using StatusCodePagesMiddleware.
     /// </summary>
-    public bool RestoreOriginalStatusCode { get; set; } = false;
+    public bool RestoreOriginalStatusCode { get; set; }
 
     /// <summary>
     /// Gets the current user's ID from the <see cref="HttpContext"/> using the <see cref="UserIdClaimType"/> claim.
@@ -57,11 +57,8 @@ public class DfeAnalyticsAspNetCoreOptions
     {
         ArgumentNullException.ThrowIfNull(httpContext);
 
-        if (UserIdClaimType is null)
-        {
-            throw new InvalidOperationException($"{nameof(UserIdClaimType)} is not configured.");
-        }
-
-        return httpContext.User.FindFirstValue(UserIdClaimType);
+        return UserIdClaimType is null
+            ? throw new InvalidOperationException($"{nameof(UserIdClaimType)} is not configured.")
+            : httpContext.User.FindFirstValue(UserIdClaimType);
     }
 }

src/Dfe.Analytics/AspNetCore/DfeAnalyticsAspNetCorePostConfigureOptions.cs

@@ -3,7 +3,9 @@
 
 namespace Dfe.Analytics.AspNetCore;
 
+#pragma warning disable CA1812
 internal class DfeAnalyticsAspNetCorePostConfigureOptions : IPostConfigureOptions<DfeAnalyticsAspNetCoreOptions>
+#pragma warning restore CA1812
 {
     public void PostConfigure(string? name, DfeAnalyticsAspNetCoreOptions options)
     {

src/Dfe.Analytics/AspNetCore/DfeAnalyticsMiddleware.cs

@@ -1,3 +1,4 @@
+using System.Globalization;
 using System.Threading.RateLimiting;
 using Microsoft.AspNetCore.Diagnostics;
 using Microsoft.AspNetCore.Http;
@@ -211,10 +212,12 @@ protected virtual void PopulateEventFromRequest(Event @event, HttpContext contex
     /// </remarks>
     /// <param name="context">The current <see cref="HttpContext"/>.</param>
     /// <returns>A <see cref="string"/> with an anonymized form of the client's IP address and user agent.</returns>
-    protected virtual string? GetAnonymizedUserAgentAndIp(HttpContext context) =>
-        context.Connection.RemoteIpAddress is not null ?
-            Event.Anonymize(context.Request.Headers.UserAgent + context.Connection.RemoteIpAddress) :
-            null;
+    protected virtual string? GetAnonymizedUserAgentAndIp(HttpContext context)
+    {
+        ArgumentNullException.ThrowIfNull(context);
+
+        return context.Connection.RemoteIpAddress is not null ? Event.Anonymize(context.Request.Headers.UserAgent + context.Connection.RemoteIpAddress) : null;
+    }
 
     /// <summary>
     /// Populates the response properties on <paramref name="event"/> with the information in <paramref name="context"/>.
@@ -228,12 +231,12 @@ protected virtual void PopulateEventFromResponse(Event @event, HttpContext conte
         ArgumentNullException.ThrowIfNull(context);
 
         @event.ResponseContentType = context.Response.ContentType;
-        @event.ResponseStatus = context.Response.StatusCode.ToString();
+        @event.ResponseStatus = context.Response.StatusCode.ToString(CultureInfo.InvariantCulture);
 
         if (AspNetCoreOptions.RestoreOriginalStatusCode &&
             context.Features.Get<IStatusCodeReExecuteFeature>() is IStatusCodeReExecuteFeature statusCodeReExecuteFeature)
         {
-            @event.ResponseStatus = statusCodeReExecuteFeature.OriginalStatusCode.ToString();
+            @event.ResponseStatus = statusCodeReExecuteFeature.OriginalStatusCode.ToString(CultureInfo.InvariantCulture);
         }
 
         // We may not have been able to get the user the first time around (depending on the order middleware is registered);

src/Dfe.Analytics/AspNetCore/EnrichWebRequestEventContext.cs

@@ -3,7 +3,7 @@
 namespace Dfe.Analytics.AspNetCore;
 
 /// <summary>
-/// Contains the <see cref="Dfe.Analytics.Event"/> and <see cref="Microsoft.AspNetCore.Http.HttpContext"/> for a request.
+/// Contains the <see cref="Analytics.Event"/> and <see cref="Microsoft.AspNetCore.Http.HttpContext"/> for a request.
 /// </summary>
 public sealed class EnrichWebRequestEventContext
 {

src/Dfe.Analytics/AspNetCore/WebRequestEventFeature.cs

@@ -46,7 +46,7 @@ public void IgnoreEvent()
     /// <summary>
     /// Whether an event has been sent for this <see cref="HttpContext"/>.
     /// </summary>
-    internal bool EventSent { get; private set; } = false;
+    internal bool EventSent { get; private set; }
 
     internal void MarkEventSent()
     {

src/Dfe.Analytics/Dfe.Analytics.csproj

@@ -15,8 +15,10 @@
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
+    <AnalysisMode>All</AnalysisMode>
+    <NoWarn>$(NoWarn);CA1716;CA1852;CA1848</NoWarn>
   </PropertyGroup>
-  
+
   <ItemGroup>
     <FrameworkReference Include="Microsoft.AspNetCore.App" PrivateAssets="all" />
     <PackageReference Include="Google.Cloud.BigQuery.V2" Version="[3.0,4.0)" />
@@ -32,5 +34,5 @@
   <ItemGroup>
     <None Include="$(RepoRoot)README.md" Pack="true" PackagePath="\" />
   </ItemGroup>
-  
+
 </Project>