Skip to content

Commit fde21b3

Browse files
authored
Fix backwards compatibility for DfE::Analytics jobs used externally (#219)
1 parent 047cb1a commit fde21b3

File tree

4 files changed

+22
-0
lines changed

4 files changed

+22
-0
lines changed

lib/dfe/analytics.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
require 'google/cloud/bigquery'
77
require 'dfe/analytics/activerecord' if defined?(ActiveRecord)
88
require 'dfe/analytics/jobs'
9+
require 'dfe/analytics/analytics_job'
10+
require 'dfe/analytics/entity_table_check_job'
911
require 'dfe/analytics/config'
1012
require 'dfe/analytics/event_schema'
1113
require 'dfe/analytics/fields'

lib/dfe/analytics/analytics_job.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
module DfE
2+
module Analytics
3+
AnalyticsJob = DfE::Analytics::Jobs::AnalyticsJob
4+
end
5+
end
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
module DfE
2+
module Analytics
3+
EntityTableCheckJob = DfE::Analytics::Jobs::EntityTableCheckJob
4+
end
5+
end

spec/dfe/analytics_spec.rb

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -385,4 +385,14 @@
385385
expect { DfE::Analytics.initialize! }.not_to raise_error
386386
end
387387
end
388+
389+
describe 'Backward compatibility constants for DfE::Analytics' do
390+
it 'aliases DfE::Analytics::AnalyticsJob to DfE::Analytics::Jobs::AnalyticsJob' do
391+
expect(DfE::Analytics::AnalyticsJob).to eq(DfE::Analytics::Jobs::AnalyticsJob)
392+
end
393+
394+
it 'aliases DfE::Analytics::EntityTableCheckJob to DfE::Analytics::Jobs::EntityTableCheckJob' do
395+
expect(DfE::Analytics::EntityTableCheckJob).to eq(DfE::Analytics::Jobs::EntityTableCheckJob)
396+
end
397+
end
388398
end

0 commit comments

Comments
 (0)