Skip to content

Commit 4c572a1

Browse files
CathLassCathLass
authored
Accessibility duplicate links (#2827)
### Changes proposed in this pull request https://trello.com/c/22QvJk0U/1955-aa004-address-duplicate-links-on-pages
1 parent 6cef817 commit 4c572a1

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

‎TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Alerts/ReopenAlert/CheckAnswers.cshtml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
<govuk-summary-list-row-key>Reason for change</govuk-summary-list-row-key>
5050
<govuk-summary-list-row-value>@Model.ChangeReason.GetDisplayName()</govuk-summary-list-row-value>
5151
<govuk-summary-list-row-actions>
52-
<govuk-summary-list-row-action href="@LinkGenerator.Alerts.ReopenAlert.Index(Model.AlertId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)">Change</govuk-summary-list-row-action>
52+
<govuk-summary-list-row-action href="@LinkGenerator.Alerts.ReopenAlert.Index(Model.AlertId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)" visually-hidden-text="reason for change">Change</govuk-summary-list-row-action>
5353
</govuk-summary-list-row-actions>
5454
</govuk-summary-list-row>
5555
<govuk-summary-list-row>
@@ -74,7 +74,7 @@
7474
<vc:evidence-file-link evidence-file="@Model.EvidenceFile" />
7575
</govuk-summary-list-row-value>
7676
<govuk-summary-list-row-actions>
77-
<govuk-summary-list-row-action href="@LinkGenerator.Alerts.ReopenAlert.Index(Model.AlertId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)">Change</govuk-summary-list-row-action>
77+
<govuk-summary-list-row-action href="@LinkGenerator.Alerts.ReopenAlert.Index(Model.AlertId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)" visually-hidden-text="evidence">Change</govuk-summary-list-row-action>
7878
</govuk-summary-list-row-actions>
7979
</govuk-summary-list-row>
8080
</govuk-summary-list>

‎TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Mqs/AddMq/CheckAnswers.cshtml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,35 +20,35 @@
2020
<govuk-summary-list-row-key>Training provider</govuk-summary-list-row-key>
2121
<govuk-summary-list-row-value data-testid="provider">@Model.ProviderName</govuk-summary-list-row-value>
2222
<govuk-summary-list-row-actions>
23-
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.AddMq.Provider(Model.PersonId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)">Change</govuk-summary-list-row-action>
23+
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.AddMq.Provider(Model.PersonId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)" visually-hidden-text="training provider">Change</govuk-summary-list-row-action>
2424
</govuk-summary-list-row-actions>
2525
</govuk-summary-list-row>
2626
<govuk-summary-list-row>
2727
<govuk-summary-list-row-key>Specialism</govuk-summary-list-row-key>
2828
<govuk-summary-list-row-value data-testid="specialism">@Model.Specialism.GetTitle()</govuk-summary-list-row-value>
2929
<govuk-summary-list-row-actions>
30-
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.AddMq.Specialism(Model.PersonId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)">Change</govuk-summary-list-row-action>
30+
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.AddMq.Specialism(Model.PersonId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)" visually-hidden-text="specialism">Change</govuk-summary-list-row-action>
3131
</govuk-summary-list-row-actions>
3232
</govuk-summary-list-row>
3333
<govuk-summary-list-row>
3434
<govuk-summary-list-row-key>Start date</govuk-summary-list-row-key>
3535
<govuk-summary-list-row-value data-testid="start-date">@Model.StartDate.ToString(UiDefaults.DateOnlyDisplayFormat)</govuk-summary-list-row-value>
3636
<govuk-summary-list-row-actions>
37-
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.AddMq.StartDate(Model.PersonId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)">Change</govuk-summary-list-row-action>
37+
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.AddMq.StartDate(Model.PersonId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)" visually-hidden-text="start date">Change</govuk-summary-list-row-action>
3838
</govuk-summary-list-row-actions>
3939
</govuk-summary-list-row>
4040
<govuk-summary-list-row>
4141
<govuk-summary-list-row-key>Status</govuk-summary-list-row-key>
4242
<govuk-summary-list-row-value data-testid="status">@Model.Status.GetTitle()</govuk-summary-list-row-value>
4343
<govuk-summary-list-row-actions>
44-
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.AddMq.Status(Model.PersonId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)">Change</govuk-summary-list-row-action>
44+
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.AddMq.Status(Model.PersonId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)" visually-hidden-text="status">Change</govuk-summary-list-row-action>
4545
</govuk-summary-list-row-actions>
4646
</govuk-summary-list-row>
4747
<govuk-summary-list-row>
4848
<govuk-summary-list-row-key>End date</govuk-summary-list-row-key>
4949
<govuk-summary-list-row-value data-testid="end-date">@(Model.EndDate.HasValue ? Model.EndDate.Value.ToString(UiDefaults.DateOnlyDisplayFormat) : "None")</govuk-summary-list-row-value>
5050
<govuk-summary-list-row-actions>
51-
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.AddMq.Status(Model.PersonId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)">Change</govuk-summary-list-row-action>
51+
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.AddMq.Status(Model.PersonId, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)" visually-hidden-text="end date">Change</govuk-summary-list-row-action>
5252
</govuk-summary-list-row-actions>
5353
</govuk-summary-list-row>
5454
</govuk-summary-list>

‎TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Persons/PersonDetail/Qualifications.cshtml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ else
172172
<govuk-summary-card-actions>
173173
@if (Model.CanEdit)
174174
{
175-
<govuk-summary-card-action href="@LinkGenerator.Mqs.DeleteMq.Index(mq.QualificationId, null)" visually-hidden-text="delete qualification" data-testid="[email protected]">Delete qualification</govuk-summary-card-action>
175+
<govuk-summary-card-action href="@LinkGenerator.Mqs.DeleteMq.Index(mq.QualificationId, null)" data-testid="[email protected]">Delete qualification</govuk-summary-card-action>
176176
}
177177
</govuk-summary-card-actions>
178178
<govuk-summary-list>
@@ -182,7 +182,7 @@ else
182182
<govuk-summary-list-row-actions>
183183
@if (Model.CanEdit)
184184
{
185-
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.EditMq.Provider.Index(mq.QualificationId, null)" class="govuk-link" visually-hidden-text="change training provider" data-testid="[email protected]">Change</govuk-summary-list-row-action>
185+
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.EditMq.Provider.Index(mq.QualificationId, null)" class="govuk-link" visually-hidden-text="training provider" data-testid="[email protected]">Change</govuk-summary-list-row-action>
186186
}
187187
</govuk-summary-list-row-actions>
188188
</govuk-summary-list-row>
@@ -192,7 +192,7 @@ else
192192
<govuk-summary-list-row-actions>
193193
@if (Model.CanEdit)
194194
{
195-
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.EditMq.Specialism.Index(mq.QualificationId, null)" class="govuk-link" visually-hidden-text="change specialism" data-testid="[email protected]">Change</govuk-summary-list-row-action>
195+
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.EditMq.Specialism.Index(mq.QualificationId, null)" class="govuk-link" visually-hidden-text="specialism" data-testid="[email protected]">Change</govuk-summary-list-row-action>
196196
}
197197
</govuk-summary-list-row-actions>
198198
</govuk-summary-list-row>
@@ -202,7 +202,7 @@ else
202202
<govuk-summary-list-row-actions>
203203
@if (Model.CanEdit)
204204
{
205-
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.EditMq.StartDate.Index(mq.QualificationId, null)" class="govuk-link" visually-hidden-text="change start date" data-testid="[email protected]">Change</govuk-summary-list-row-action>
205+
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.EditMq.StartDate.Index(mq.QualificationId, null)" class="govuk-link" visually-hidden-text="start date" data-testid="[email protected]">Change</govuk-summary-list-row-action>
206206
}
207207
</govuk-summary-list-row-actions>
208208
</govuk-summary-list-row>
@@ -212,7 +212,7 @@ else
212212
<govuk-summary-list-row-actions>
213213
@if (Model.CanEdit)
214214
{
215-
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.EditMq.Status.Index(mq.QualificationId, null)" visually-hidden-text="change status" data-testid="[email protected]">Change</govuk-summary-list-row-action>
215+
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.EditMq.Status.Index(mq.QualificationId, null)" visually-hidden-text="status" data-testid="[email protected]">Change</govuk-summary-list-row-action>
216216
}
217217
</govuk-summary-list-row-actions>
218218
</govuk-summary-list-row>
@@ -222,7 +222,7 @@ else
222222
<govuk-summary-list-row-actions>
223223
@if (Model.CanEdit)
224224
{
225-
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.EditMq.Status.Index(mq.QualificationId, null)" visually-hidden-text="change end date" data-testid="[email protected]">Change</govuk-summary-list-row-action>
225+
<govuk-summary-list-row-action href="@LinkGenerator.Mqs.EditMq.Status.Index(mq.QualificationId, null)" visually-hidden-text="end date" data-testid="[email protected]">Change</govuk-summary-list-row-action>
226226
}
227227
</govuk-summary-list-row-actions>
228228
</govuk-summary-list-row>

‎TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/SupportTasks/NpqTrnRequests/Reject/CheckAnswers.cshtml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<govuk-summary-list-row-key>Reason</govuk-summary-list-row-key>
2020
<govuk-summary-list-row-value use-empty-fallback>@Model.RejectionReason?.GetDisplayName()</govuk-summary-list-row-value>
2121
<govuk-summary-list-row-actions>
22-
<govuk-summary-list-row-action href="@LinkGenerator.SupportTasks.NpqTrnRequests.Reject.Reason(Model.SupportTaskReference, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)" data-testid="change-link">Change</govuk-summary-list-row-action>
22+
<govuk-summary-list-row-action href="@LinkGenerator.SupportTasks.NpqTrnRequests.Reject.Reason(Model.SupportTaskReference, Model.JourneyInstance!.InstanceId, fromCheckAnswers: true)" data-testid="change-link" visually-hidden-text="reason">Change</govuk-summary-list-row-action>
2323
</govuk-summary-list-row-actions>
2424
</govuk-summary-list-row>
2525
</govuk-summary-list>

‎TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/SupportTasks/TeacherPensions/Resolve/ConfirmKeepRecordSeparateReason.cshtml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<govuk-summary-list-row-value>@Model.GetReason()</govuk-summary-list-row-value>
2020
<govuk-summary-list-row-actions>
2121
<govuk-summary-list-row-action href="@LinkGenerator.SupportTasks.TeacherPensions.Resolve.KeepRecordSeparate(Model.SupportTaskReference!, Model.JourneyInstance!.InstanceId)"
22-
visually-hidden-text="reason for change">Change</govuk-summary-list-row-action>
22+
visually-hidden-text="reason">Change</govuk-summary-list-row-action>
2323
</govuk-summary-list-row-actions>
2424
</govuk-summary-list-row>
2525
</govuk-summary-list>

0 commit comments

Comments
 (0)