Remove final DQT references (#2854)

Also fixes up a load of build warnings that have suddenly started
appearing.

Author: gunndabad

TeachingRecordSystem/Directory.Build.props

@@ -17,6 +17,7 @@
     <UserSecretsId>TeachingRecordSystem</UserSecretsId>
     <UserSecretsId Condition="'$(IsTestProject)' == 'true'">TeachingRecordSystemTests</UserSecretsId>
 
+    <NoWarn>CA1711;CA1304;CA1310;CA1311;CA2254</NoWarn>
     <NoWarn Condition="'$(IsTestProject)' == 'true'">$(NoWarn);CA1707;CA1711;CA1816;TUnit0046;xUnit1051</NoWarn>
   </PropertyGroup>
 

TeachingRecordSystem/Directory.Packages.props

@@ -62,8 +62,6 @@
     <PackageVersion Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="8.14.0" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
     <PackageVersion Include="Microsoft.Playwright" Version="1.55.0" />
-    <PackageVersion Include="Microsoft.PowerPlatform.Dataverse.Client" Version="1.2.10" />
-    <PackageVersion Include="Microsoft.PowerPlatform.Dataverse.Client.Dynamics" Version="1.2.10" />
     <PackageVersion Include="Microsoft.Testing.Extensions.TrxReport" Version="1.8.2" />
     <PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.14.15" />
     <PackageVersion Include="Microsoft.Web.LibraryManager.Build" Version="3.0.71" />
@@ -112,4 +110,4 @@
     <PackageVersion Include="xunit.v3.assert" Version="3.2.0" />
     <PackageVersion Include="xunit.v3.extensibility.core" Version="3.2.0" />
   </ItemGroup>
-</Project>
+</Project>

TeachingRecordSystem/src/TeachingRecordSystem.Api/V1/Handlers/GetTeacherHandler.cs

@@ -3,8 +3,6 @@
 using TeachingRecordSystem.Api.V1.Requests;
 using TeachingRecordSystem.Api.V1.Responses;
 using TeachingRecordSystem.Core.DataStore.Postgres;
-using TeachingRecordSystem.Core.Dqt;
-using TeachingRecordSystem.Core.Dqt.Models;
 
 namespace TeachingRecordSystem.Api.V1.Handlers;
 
@@ -17,7 +15,7 @@ public async Task<GetTeacherResponse> Handle(GetTeacherRequest request, Cancella
             return null;
         }
 
-        var birthDate = request.BirthDate.ToDateOnlyWithDqtBstFix(isLocalTime: false)!.Value.ToString("yyyy-MM-dd");
+        var birthDate = request.BirthDate!.Value.ToString("yyyy-MM-dd");
         var nationalInsuranceNumber = NationalInsuranceNumber.Normalize(request.NationalInsuranceNumber);
 
         var matched = await dbContext.Persons.FromSql(
@@ -65,7 +63,7 @@ public async Task<GetTeacherResponse> Handle(GetTeacherRequest request, Cancella
             Name = StringHelper.JoinNonEmpty(' ', person.FirstName, person.MiddleName, person.LastName),
             DateOfBirth = person.DateOfBirth.ToDateTime(),
             ActiveAlert = person.HasOpenAlert,
-            State = ContactState.Active,
+            State = 0,
             StateName = "Active"
         };
 
@@ -79,7 +77,7 @@ Induction MapInduction()
                     StartDate = person.InductionStartDate.ToDateTime(),
                     CompletionDate = person.InductionCompletedDate.ToDateTime(),
                     InductionStatusName = statusDescription,
-                    State = dfeta_inductionState.Active,
+                    State = 0,
                     StateName = "Active"
                 } :
                 null;
@@ -92,7 +90,7 @@ QualifiedTeacherStatus MapQualifiedTeacherStatus()
                 return new QualifiedTeacherStatus
                 {
                     Name = "",
-                    State = dfeta_qtsregistrationState.Active,
+                    State = 0,
                     StateName = "Active",
                     QtsDate = person.QtsDate.ToDateTime()
                 };
@@ -101,8 +99,4 @@ QualifiedTeacherStatus MapQualifiedTeacherStatus()
             return null;
         }
     }
-
-#pragma warning disable IDE1006 // Naming Styles
-    private record PersonIdResult(Guid person_id);
-#pragma warning restore IDE1006 // Naming Styles
 }

TeachingRecordSystem/src/TeachingRecordSystem.Api/V1/Responses/GetTeacherResponse.cs

@@ -1,6 +1,5 @@
 #nullable disable
 using System.Text.Json.Serialization;
-using TeachingRecordSystem.Core.Dqt.Models;
 
 namespace TeachingRecordSystem.Api.V1.Responses;
 
@@ -39,3 +38,8 @@ public class GetTeacherResponse
     [JsonPropertyName("state_name")]
     public string StateName { get; set; }
 }
+
+public enum ContactState
+{
+    Active = 0
+}

TeachingRecordSystem/src/TeachingRecordSystem.Api/V1/Responses/Induction.cs

@@ -1,6 +1,5 @@
 #nullable disable
 using System.Text.Json.Serialization;
-using TeachingRecordSystem.Core.Dqt.Models;
 
 namespace TeachingRecordSystem.Api.V1.Responses;
 
@@ -21,3 +20,10 @@ public class Induction
     [JsonPropertyName("state_name")]
     public string StateName { get; set; }
 }
+
+#pragma warning disable CA1707
+public enum dfeta_inductionState
+#pragma warning restore CA1707
+{
+    Active = 0
+}

TeachingRecordSystem/src/TeachingRecordSystem.Api/V1/Responses/InitialTeacherTraining.cs

@@ -1,6 +1,5 @@
 #nullable disable
 using System.Text.Json.Serialization;
-using TeachingRecordSystem.Core.Dqt.Models;
 
 namespace TeachingRecordSystem.Api.V1.Responses;
 
@@ -45,3 +44,10 @@ public class InitialTeacherTraining
     [JsonPropertyName("subject3_code")]
     public string Subject3Code { get; set; }
 }
+
+#pragma warning disable CA1707
+public enum dfeta_initialteachertrainingState
+#pragma warning restore CA1707
+{
+    Active = 0
+}

TeachingRecordSystem/src/TeachingRecordSystem.Api/V1/Responses/QualifiedTeacherStatus.cs

@@ -1,6 +1,5 @@
 #nullable disable
 using System.Text.Json.Serialization;
-using TeachingRecordSystem.Core.Dqt.Models;
 
 namespace TeachingRecordSystem.Api.V1.Responses;
 
@@ -18,3 +17,10 @@ public class QualifiedTeacherStatus
     [JsonPropertyName("qts_date")]
     public DateTime? QtsDate { get; set; }
 }
+
+#pragma warning disable CA1707
+public enum dfeta_qtsregistrationState
+#pragma warning restore CA1707
+{
+    Active = 0
+}

TeachingRecordSystem/src/TeachingRecordSystem.Api/V2/ApiModels/Gender.cs

@@ -1,5 +1,4 @@
 #nullable disable
-using TeachingRecordSystem.Core.Dqt.Models;
 
 namespace TeachingRecordSystem.Api.V2.ApiModels;
 
@@ -11,14 +10,3 @@ public enum Gender
     NotAvailable = 389040002,
     NotProvided = 389040001
 }
-
-#pragma warning disable CA1707
-public static class GenderExtensions
-{
-    public static Contact_GenderCode ConvertToContact_GenderCode(this Gender input) =>
-        input.ConvertToEnumByValue<Gender, Contact_GenderCode>();
-
-    public static bool TryConvertToContact_GenderCode(this Gender input, out Contact_GenderCode result) =>
-        input.TryConvertToEnumByValue(out result);
-}
-#pragma warning restore CA1707

TeachingRecordSystem/src/TeachingRecordSystem.Api/V3/Implementation/Dtos/DqtInductionStatus.cs

@@ -1,5 +1,3 @@
-using TeachingRecordSystem.Core.Dqt.Models;
-
 namespace TeachingRecordSystem.Api.V3.Implementation.Dtos;
 
 public enum DqtInductionStatus
@@ -17,22 +15,6 @@ public enum DqtInductionStatus
 
 public static class DqtInductionStatusExtensions
 {
-    public static DqtInductionStatus ConvertToDqtInductionStatus(this dfeta_InductionStatus input) => input switch
-    {
-        dfeta_InductionStatus.Exempt => DqtInductionStatus.Exempt,
-        dfeta_InductionStatus.Fail => DqtInductionStatus.Fail,
-        dfeta_InductionStatus.FailedinWales => DqtInductionStatus.FailedInWales,
-        dfeta_InductionStatus.InductionExtended => DqtInductionStatus.InductionExtended,
-        dfeta_InductionStatus.InProgress => DqtInductionStatus.InProgress,
-        dfeta_InductionStatus.NotYetCompleted => DqtInductionStatus.NotYetCompleted,
-        dfeta_InductionStatus.Pass => DqtInductionStatus.Pass,
-        dfeta_InductionStatus.PassedinWales => DqtInductionStatus.PassedInWales,
-        dfeta_InductionStatus.RequiredtoComplete => DqtInductionStatus.RequiredToComplete,
-        _ => throw new ArgumentException($"Unknown {nameof(DqtInductionStatus)}: '{input}'.")
-    };
-
-    public static string GetDescription(this dfeta_InductionStatus input) => ConvertToDqtInductionStatus(input).GetDescription();
-
     public static string GetDescription(this DqtInductionStatus input) => input switch
     {
         DqtInductionStatus.Exempt => "Exempt",