Don't allow deleting of organisations with vacancies

Author: KyleMacPherson

app/models/organisation.rb

@@ -15,7 +15,7 @@ class Organisation < ApplicationRecord
   has_one_attached :logo, service: :azure_storage_images_and_logos
   has_one_attached :photo, service: :azure_storage_images_and_logos
 
-  has_many :organisation_vacancies, dependent: :destroy
+  has_many :organisation_vacancies, dependent: :restrict_with_error
   has_many :vacancies, through: :organisation_vacancies
   has_many :publisher_vacancies, class_name: "Vacancy", foreign_key: :publisher_organisation_id, dependent: :destroy
 

spec/models/organisation_spec.rb

@@ -243,4 +243,20 @@
       end
     end
   end
+
+  describe "deletion restrictions" do
+    context "when organisation has vacancies" do
+      let(:organisation) { create(:school) }
+      let!(:vacancy) { create(:vacancy, organisations: [organisation]) }
+
+      it "prevents deletion" do
+        expect { organisation.destroy }.not_to change(Organisation, :count)
+      end
+
+      it "adds an error to the organisation" do
+        organisation.destroy
+        expect(organisation.errors[:base]).to include("Cannot delete record because dependent organisation vacancies exist")
+      end
+    end
+  end
 end