map legacy working patterns from profile (#8529)

Author: starswan

app/services/jobseekers/job_applications/prefill_job_application_from_jobseeker_profile.rb

@@ -6,6 +6,7 @@ def initialize(jobseeker, new_job_application)
 
   def call
     copy_personal_info
+    copy_job_preferences(jobseeker_profile.job_preferences) if jobseeker_profile.job_preferences.present?
     copy_associations(jobseeker_profile.qualifications)
     copy_associations(jobseeker_profile.employments)
     copy_associations(jobseeker_profile.training_and_cpds)
@@ -29,8 +30,16 @@ def copy_personal_info
       qts_age_range_and_subject: jobseeker_profile.qts_age_range_and_subject,
       teacher_reference_number: jobseeker_profile.teacher_reference_number,
       has_right_to_work_in_uk: jobseeker_profile.personal_details&.has_right_to_work_in_uk?,
-      working_patterns: jobseeker_profile.job_preferences&.working_patterns,
-      working_pattern_details: jobseeker_profile.job_preferences&.working_pattern_details,
+    )
+  end
+
+  def copy_job_preferences(job_preferences)
+    # JobPreference working patterns are stored as strings, but JobApplication working_patterns are stored as
+    # mapped integers. This is defensive code to stop crashes if/when these 2 items get out of alignment
+    # (which has happened recently with the retirement of 'flexible' and 'term_time' options)
+    new_job_application.assign_attributes(
+      working_patterns: job_preferences.working_patterns.select { |wp| JobApplication.working_patterns.key?(wp.to_sym) },
+      working_pattern_details: job_preferences.working_pattern_details,
     )
   end
 

db/seeds.rb

@@ -126,7 +126,7 @@
                       qualifications: FactoryBot.build_list(:qualification, 1, job_application: nil),
                       employments: FactoryBot.build_list(:employment, 1, :jobseeker_profile_employment),
                       jobseeker: jobseeker) do |jobseeker_profile|
-      FactoryBot.create(:job_preferences, jobseeker_profile: jobseeker_profile) do |job_preferences|
+      FactoryBot.create(:job_preferences, :for_seed_data, jobseeker_profile: jobseeker_profile) do |job_preferences|
         FactoryBot.create(:job_preferences_location, job_preferences:, name: location_preference_names.sample)
       end
     end

lib/tasks/migrate_legacy_job_preferences.rake

@@ -0,0 +1,12 @@
+desc "Migrate legacy job preferences"
+task migrate_legacy_job_preferences: :environment do
+  JobPreferences.where.not(working_patterns: nil).find_each do |jp|
+    if jp.working_patterns.include?("term_time")
+      jp.assign_attributes(working_patterns: (jp.working_patterns - %w[term_time] + %w[full_time]).uniq)
+    end
+    if jp.working_patterns.include?("flexible")
+      jp.assign_attributes(working_patterns: (jp.working_patterns - %w[flexible] + %w[part_time]).uniq)
+    end
+    jp.save!(validate: false, touch: false)
+  end
+end

spec/factories/job_preferences.rb

@@ -1,10 +1,10 @@
 FactoryBot.define do
   factory :job_preferences do
-    roles { factory_rand_sample(Vacancy.job_roles.keys, 1..Vacancy.job_roles.keys.count) }
-    phases { factory_rand_sample(Vacancy.phases.keys, 1..Vacancy.phases.keys.count) }
+    roles { Vacancy.job_roles.keys }
+    phases { Vacancy.phases.keys }
     key_stages { key_stages_for_phases }
-    subjects { factory_rand_sample(SUBJECT_OPTIONS.map(&:first), 1..3) }
-    working_patterns { factory_rand_sample(Vacancy.working_patterns.keys, 1..2) }
+    subjects { SUBJECT_OPTIONS.map(&:first) }
+    working_patterns { Vacancy.working_patterns.keys }
     working_pattern_details { "Strictly no Mondays" }
     builder_completed { true }
     completed_steps do
@@ -24,6 +24,13 @@
       locations { [build(:job_preferences_location, name: Faker::Address.postcode, radius: Faker::Number.between(from: 1, to: 200), job_preferences: instance)] }
     end
 
+    trait :for_seed_data do
+      working_patterns { factory_rand_sample(Vacancy.working_patterns.keys, 1..2) }
+      roles { factory_rand_sample(Vacancy.job_roles.keys, 1..Vacancy.job_roles.keys.count) }
+      phases { factory_rand_sample(Vacancy.phases.keys, 1..Vacancy.phases.keys.count) }
+      subjects { factory_rand_sample(SUBJECT_OPTIONS.map(&:first), 1..3) }
+    end
+
     trait :incomplete do
       builder_completed { false }
       completed_steps { {} }

spec/lib/tasks/migrate_legacy_job_preferences_task_spec.rb

@@ -0,0 +1,29 @@
+require "rails_helper"
+
+RSpec.describe "migrate_legacy_job_preferences" do
+  include_context "rake"
+
+  let!(:pref_a) { create(:job_preferences, working_patterns: %w[term_time flexible part_time]) }
+  let!(:pref_b) { create(:job_preferences, working_patterns: %w[flexible full_time]) }
+  let!(:pref_c) { create(:job_preferences, working_patterns: %w[term_time]) }
+
+  # rubocop:disable RSpec/NamedSubject
+  before do
+    create(:job_preferences)
+    create(:job_preferences, working_patterns: nil)
+    subject.invoke
+  end
+  # rubocop:enable RSpec/NamedSubject
+
+  it "fixes up term time flexible" do
+    expect(pref_a.reload.working_patterns).to match_array(%w[full_time part_time])
+  end
+
+  it "fixes up flexible full_time" do
+    expect(pref_b.reload.working_patterns).to match_array(%w[part_time full_time])
+  end
+
+  it "fixes up term_time" do
+    expect(pref_c.reload.working_patterns).to match_array(%w[full_time])
+  end
+end

spec/services/jobseekers/job_applications/prefill_job_application_from_jobseeker_profile_spec.rb

@@ -3,7 +3,11 @@
 RSpec.describe Jobseekers::JobApplications::PrefillJobApplicationFromJobseekerProfile do
   let(:jobseeker) { create(:jobseeker) }
   let(:new_vacancy) { create(:vacancy) }
-  let!(:jobseeker_profile) { create(:jobseeker_profile, :completed, jobseeker: jobseeker) }
+  let!(:jobseeker_profile) do
+    create(:jobseeker_profile, :completed,
+           jobseeker: jobseeker,
+           job_preferences: build(:job_preferences, working_patterns: build_stubbed(:job_preferences).working_patterns + %w[term_time flexible]))
+  end
   let(:new_job_application) { jobseeker.job_applications.create(vacancy: new_vacancy) }
 
   subject { described_class.new(jobseeker, new_job_application).call }
@@ -20,6 +24,10 @@
       .to eq(jobseeker_profile.qualifications.map { |qualification| qualification.slice(*attributes_to_copy) })
   end
 
+  it "removes legacy working patterns" do
+    expect(subject.working_patterns).to eq(%w[full_time part_time job_share])
+  end
+
   it "adds qualifications to in progress steps" do
     expect(subject.in_progress_steps).to include("qualifications")
   end

spec/system/publishers/publishers_can_view_candidate_messages_spec.rb

@@ -28,6 +28,7 @@
         visit publishers_candidate_messages_path
         # wait for page load
         find("form[action='/publishers/candidate_messages/toggle_archive']")
+        find("footer")
       end
 
       it "passes accessibility checks", :a11y do