Convert from lcov to undercover format (#8579)

Author: starswan

.ruby-version

@@ -1 +1 @@
-3.4.8
+3.4.8

.simplecov

@@ -7,23 +7,19 @@
 # for this to be valuable so that only changed files have tests run
 if ENV.fetch("COVERAGE", 0).to_i.positive?
   require "simplecov"
-  require "simplecov-lcov"
+  require "undercover/simplecov_formatter"
 
   # This allows both LCOV and HTML formatting -
   # lcov for undercover gem, HTML for humans
-  class SimpleCov::Formatter::MergedFormatter
-    def format(result)
-      SimpleCov::Formatter::HTMLFormatter.new.format(result)
-      SimpleCov::Formatter::LcovFormatter.new.format(result)
-    end
-  end
-
-  SimpleCov::Formatter::LcovFormatter.config.report_with_single_file = true
-  SimpleCov.formatter = SimpleCov::Formatter::MergedFormatter
+  SimpleCov.formatters = SimpleCov::Formatter::MultiFormatter.new(
+    [
+      SimpleCov::Formatter::Undercover,
+      SimpleCov::Formatter::HTMLFormatter,
+    ],
+  )
 
   SimpleCov.start :rails do
     enable_coverage :branch
-    primary_coverage :branch
 
     # This line would enable coverage for view templates, but the slim compiler
     # appears to have a bug which puts the whole coverage data out by one line.
@@ -67,9 +63,9 @@ if ENV.fetch("COVERAGE", 0).to_i.positive?
     # However (possibly due to some residual random behaviour in test factories)
     # the line coverage needs to be set 0.02 below the reported value.
     # Nornmally this value needs to be 0.01 below the reported value due to rounding issues.
-    minimum_coverage line: 97.40, branch: 87.23
-    # Values from test run Fri 13th February 2026
-    # 97.46% (12553 / 12880) -> 327 lines uncovered
-    # 87.18% (2808 / 3221) -> 192 + 221 = 411 branches uncovered
+    minimum_coverage line: 97.22, branch: 87.23
+    # Values from test run Wed 4th March 2026
+    # 97.43% (12677 / 13011) -> 334 lines uncovered
+    # 87.19% (2812 / 3225) -> 188 + 225 = 413 branches uncovered
   end
 end

Gemfile

@@ -154,8 +154,6 @@ group :test do
   gem "selenium-webdriver"
   gem "shoulda-matchers"
   gem "simplecov", require: false
-  # Lcov 0.9 breaks undercover's LCov parser
-  gem "simplecov-lcov", "< 0.10", require: false
   gem "site_prism"
   gem "uri-query_params"
   gem "vcr"

Gemfile.lock

@@ -831,7 +831,6 @@ GEM
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.13.2)
-    simplecov-lcov (0.9.0)
     simplecov_json_formatter (0.1.4)
     site_prism (5.1.1)
       addressable (~> 2.8, >= 2.8.4)
@@ -1100,7 +1099,6 @@ DEPENDENCIES
   sidekiq-cron
   sidekiq-limit_fetch
   simplecov
-  simplecov-lcov (< 0.10)
   site_prism
   skylight
   slim-rails
@@ -1426,7 +1424,6 @@ CHECKSUMS
   signet (0.21.0) sha256=d617e9fbf24928280d39dcfefba9a0372d1c38187ffffd0a9283957a10a8cd5b
   simplecov (0.22.0) sha256=fe2622c7834ff23b98066bb0a854284b2729a569ac659f82621fc22ef36213a5
   simplecov-html (0.13.2) sha256=bd0b8e54e7c2d7685927e8d6286466359b6f16b18cb0df47b508e8d73c777246
-  simplecov-lcov (0.9.0) sha256=7a77a31e200a595ed4b0249493056efd0c920601f53d2ef135ca34ee796346cd
   simplecov_json_formatter (0.1.4) sha256=529418fbe8de1713ac2b2d612aa3daa56d316975d307244399fa4838c601b428
   site_prism (5.1.1) sha256=9f89c8911dbc1c94e6eaf0b850eca034c71cfce0bc6f2304d982b15a64af5891
   site_prism-all_there (3.0.7) sha256=87b344fba06ddd8a21569b66558ab549226991b3c5a5076bfd2561950c5e6473

spec/factories/vacancies.rb

@@ -107,7 +107,6 @@
       is_job_share { [true, false].sample }
       working_patterns { factory_rand_sample(%w[full_time part_time], 1..2) }
       working_patterns_details { Faker::Lorem.sentence(word_count: factory_rand(1..50)) }
-      # rand_phases = factory_rand_sample(Vacancy.phases.keys, 1..3)
       phases { factory_rand_sample(Vacancy.phases.keys, 1..3) }
 
       # Subjects are ignored when phases don't include secondary