remove unused hook (#8567)

Author: starswan

.simplecov

@@ -67,7 +67,7 @@ if ENV.fetch("COVERAGE", 0).to_i.positive?
     # However (possibly due to some residual random behaviour in test factories)
     # the line coverage needs to be set 0.02 below the reported value.
     # Nornmally this value needs to be 0.01 below the reported value due to rounding issues.
-    minimum_coverage line: 97.43, branch: 87.23
+    minimum_coverage line: 97.40, branch: 87.23
     # Values from test run Fri 13th February 2026
     # 97.46% (12553 / 12880) -> 327 lines uncovered
     # 87.18% (2808 / 3221) -> 192 + 221 = 411 branches uncovered

app/form_models/base_form.rb

@@ -1,6 +1,4 @@
 class BaseForm
-  attr_accessor :skip_after_validation_big_query_callback
-
   IMAGE_VALIDATION_OPTIONS = {
     file_type: :image,
     content_types_allowed: %w[image/jpeg image/png].freeze,
@@ -13,7 +11,7 @@ class BaseForm
   include ActiveModel::Model
   include ActiveModel::Validations::Callbacks
 
-  after_validation :send_errors_to_big_query, unless: :skip_after_validation_big_query_callback
+  after_validation :send_errors_to_big_query
 
   def send_errors_to_big_query
     return if errors.none?

spec/system/publishers/publishers_can_message_multiple_job_candidates_spec.rb

@@ -33,7 +33,7 @@
         first(".govuk-checkboxes__item").click
         click_on "Send a message"
         #  wait for page to load
-        find("span", text: "Send messages")
+        find(".trix-content")
 
         click_on "Send message without template"
         fill_in_trix_editor "publisher_message_content", with: Faker::ChuckNorris.fact