tidy up

Author: starswan

app/controllers/sitemap_controller.rb

@@ -2,34 +2,22 @@ class SitemapController < ApplicationController
   STATIC_PAGES = %w[terms-and-conditions savings-methodology accessibility vision-statement].freeze
   POST_SECTION_NAMES = %w[get-help-hiring jobseeker-guides].freeze
 
-  # rubocop:disable Metrics/AbcSize
   def show
-    map = XmlSitemap::Map.new(service_domain, secure: !Rails.env.development?) do |m|
-      add_live_vacancies(m)
+    map = XmlSitemap::Map.new(service_domain, secure: !Rails.env.development?) do |sitemap|
+      add_live_vacancies(sitemap)
 
-      add_static_landing_pages(m)
+      add_static_landing_pages(sitemap)
 
-      add_location_landing_pages(m)
+      add_location_landing_pages(sitemap)
 
-      STATIC_PAGES.each { |static_page| m.add page_path(static_page), period: "weekly" }
+      STATIC_PAGES.each { |static_page| sitemap.add page_path(static_page), period: "weekly" }
 
-      POST_SECTION_NAMES.each do |section|
-        m.add posts_path(section), period: "weekly"
-
-        MarkdownDocument.all_subcategories(section).each do |sub_category|
-          m.add subcategory_path(section, sub_category.post_name), period: "weekly"
-          posts = MarkdownDocument.all(section, sub_category.post_name)
-          posts.each do |post|
-            m.add post_path(section, sub_category.post_name, post.post_name), period: "weekly"
-          end
-        end
-      end
+      add_all_posts(sitemap)
     end
 
     expires_in 3.hours
     render xml: map.render
   end
-  # rubocop:enable Metrics/AbcSize
 
   private
 
@@ -50,4 +38,18 @@ def add_location_landing_pages(sitemap)
       sitemap.add location_landing_page_path(location.parameterize), period: "hourly"
     end
   end
+
+  def add_all_posts(sitenap)
+    POST_SECTION_NAMES.each do |section|
+      sitenap.add posts_path(section), period: "weekly"
+
+      MarkdownDocument.all_subcategories(section).each do |sub_category|
+        sitenap.add subcategory_path(section, sub_category.post_name), period: "weekly"
+        posts = MarkdownDocument.all(section, sub_category.post_name)
+        posts.each do |post|
+          sitenap.add post_path(section, sub_category.post_name, post.post_name), period: "weekly"
+        end
+      end
+    end
+  end
 end