Refactor: Move vacancy backfilling to Vacancy

Since is internal Vacancy logic with no other dependencies or
complexity, it seems appropriate to tell "Vacancy" to backfill their
missing values.

Author: scruti

app/models/vacancy.rb

@@ -297,6 +297,19 @@ def contact_email_belongs_to_a_publisher?
     Publisher.find_by(email: contact_email).present?
   end
 
+  def self.backfill_missing_geolocations
+    where(geolocation: nil).find_each do |v|
+      v.send(:refresh_geolocation)
+      v.save!(touch: false, validate: false)
+    end
+  end
+
+  def self.backfill_missing_searchable_content
+    where(searchable_content: nil).find_each do |v|
+      v.save!(touch: false, validate: false)
+    end
+  end
+
   private
 
   def update_conversation_searchable_content

app/services/backfills/vacancy_geolocation.rb

@@ -69,12 +69,12 @@ end
 namespace :backfills do
   desc "Backfill vacancy geolocation"
   task vacancy_geolocation: :environment do
-    Backfills::VacancyGeolocation.call
+    Vacancy.backfill_missing_geolocations
   end
 
   desc "Backfill vacancy searchable content"
   task vacancy_searchable_content: :environment do
-    Backfills::VacancySearchableContent.call
+    Vacancy.backfill_missing_searchable_content
   end
 end
 

app/services/backfills/vacancy_searchable_content.rb

@@ -892,4 +892,54 @@
       end
     end
   end
+
+  describe ".backfill_missing_geolocations" do
+    context "when there are vacancies without geolocation" do
+      let!(:vacancy) { create(:vacancy) }
+      let!(:another_vacancy) { create(:vacancy) }
+
+      before do
+        vacancy.update_column(:geolocation, nil)
+        another_vacancy.update_column(:geolocation, nil)
+      end
+
+      it "populates geolocation for vacancies missing it" do
+        expect { described_class.backfill_missing_geolocations }.to change { vacancy.reload.geolocation }.from(nil)
+                                                                 .and change { another_vacancy.reload.geolocation }.from(nil)
+      end
+    end
+
+    context "when a vacancy already has a geolocation" do
+      let!(:vacancy) { create(:vacancy) }
+
+      it "does not modify it" do
+        expect { described_class.backfill_missing_geolocations }.not_to(change { vacancy.reload.geolocation })
+      end
+    end
+  end
+
+  describe ".backfill_missing_searchable_content" do
+    context "when there are vacancies without searchable_content" do
+      let!(:vacancy) { create(:vacancy) }
+      let!(:another_vacancy) { create(:vacancy) }
+
+      before do
+        vacancy.update_column(:searchable_content, nil)
+        another_vacancy.update_column(:searchable_content, nil)
+      end
+
+      it "populates searchable_content for vacancies missing it" do
+        expect { described_class.backfill_missing_searchable_content }.to change { vacancy.reload.searchable_content }.from(nil)
+                                                                      .and change { another_vacancy.reload.searchable_content }.from(nil)
+      end
+    end
+
+    context "when a vacancy already has searchable_content" do
+      let!(:vacancy) { create(:vacancy) }
+
+      it "does not change it" do
+        expect { described_class.backfill_missing_searchable_content }.not_to(change { vacancy.reload.searchable_content })
+      end
+    end
+  end
 end