Tweaks after prod review

Author: starswan

app/controllers/publishers/vacancies/job_applications/references_controller.rb

@@ -7,12 +7,12 @@ class ReferencesController < BaseController
         before_action :set_job_application
 
         def new
-          @notes_form = Publishers::JobApplication::NotesForm.new
+          @note = @job_application.notes.build
           @referee = RefereeForm.new
         end
 
         def create
-          @notes_form = Publishers::JobApplication::NotesForm.new
+          @note = @job_application.notes.build
           @referee = RefereeForm.new(referee_form_params)
           if @referee.valid?
             process_referee_details @referee

app/views/jobseekers/job_applications/build/referees.html.slim

@@ -29,7 +29,7 @@ p.govuk-body = t(".description_html", link: govuk_link_to(t(".kcsie"), "https://
   = govuk_button_link_to t("buttons.add_another_reference"), new_jobseekers_job_application_referee_path(job_application)
 - else
   = render EmptySectionComponent.new title: t(".no_references") do
-    = govuk_button_link_to t("buttons.add_reference"), new_jobseekers_job_application_referee_path(job_application), class: "govuk-!-margin-bottom-0"
+    = govuk_button_link_to t("buttons.add_referee"), new_jobseekers_job_application_referee_path(job_application), class: "govuk-!-margin-bottom-0"
 
 = form_for @form, url: jobseekers_job_application_build_path(job_application, :referees), method: :patch do |f|
   = f.govuk_error_summary

app/views/publishers/vacancies/job_applications/references/new.html.slim

@@ -34,5 +34,5 @@ h1.govuk-heading-l = t(".heading")
       = f.govuk_submit t(".submit")
 
   .govuk-grid-column-one-third
-    = render PublisherNotesOnJobApplicationComponent.new(job_application: @job_application, vacancy: @vacancy, notes_form: @notes_form,
+    = job_application_notes(job_application: @job_application, vacancy: @vacancy, note: @note,
         return_to_url: new_organisation_job_job_application_reference_path(@vacancy.id, @job_application.id))

config/locales/forms.yml

@@ -15,7 +15,8 @@ en:
     add_another_training: Add another training
     add_another_professional_body_membership: Add another membership
     add_professional_body_membership: Add membership
-    add_reference: Add a referee
+    add_referee: Add a referee
+    add_reference: Add a reference
     add_work_history: Add work history
     apply_filters: Apply filters
     back: Back

config/locales/publishers/vacancies/job_applications/referee_form.en.yml

@@ -15,6 +15,8 @@ en:
               blank: Referee organisation can't be blank
             relationship:
               blank: Referee relationship can't be blank
+            reference_document:
+              blank: You must upload a file
   helpers:
     legend:
       publishers_vacancies_job_applications_referee_form:
@@ -31,8 +33,9 @@ en:
         job_title: Referee job title
         organisation: Referee organisation
         relationship: Referee relationship to applicant
-        phone_number: Referee phone number
+        phone_number: Referee phone number (Optional)
 
     hint:
       publishers_vacancies_job_applications_referee_form:
         uploaded_details: Select one option
+        job_title: When you complete these fields and select ‘Save reference’, we’ll email this person to request a reference.

spec/system/jobseekers/jobseekers_can_add_references_to_their_job_application_spec.rb

@@ -26,7 +26,7 @@
 
     context "when adding a referee" do
       before do
-        click_on I18n.t("buttons.add_reference")
+        click_on I18n.t("buttons.add_referee")
       end
 
       it "passes a11y", :a11y do

spec/system/jobseekers/jobseekers_can_complete_a_job_application_spec.rb

@@ -103,7 +103,7 @@
 
       click_on(I18n.t("jobseekers.job_applications.build.referees.heading"))
 
-      click_on I18n.t("buttons.add_reference")
+      click_on I18n.t("buttons.add_referee")
       click_on I18n.t("buttons.save_reference")
       expect(page).to have_content("There is a problem")
       fill_in_referee

spec/system/jobseekers/jobseekers_can_complete_a_religious_job_application_spec.rb

@@ -365,7 +365,7 @@ def fill_in_application_up_to_and_including_personal_statement
 
   def complete_from_references_page
     click_on(I18n.t("jobseekers.job_applications.build.referees.heading"))
-    click_on I18n.t("buttons.add_reference")
+    click_on I18n.t("buttons.add_referee")
     fill_in_referee
     click_on I18n.t("buttons.save_reference")
     click_on I18n.t("buttons.add_another_reference")

spec/system/publishers/publishers_can_add_a_manual_reference_spec.rb

@@ -16,7 +16,7 @@
   before do
     login_publisher(publisher: publisher, organisation: organisation)
     publisher_ats_pre_interview_checks_page.load(vacancy_id: vacancy.id, job_application_id: job_application.id)
-    click_on "Add a referee"
+    click_on "Add a reference"
   end
 
   after { logout }