Refactor

Author: KyleMacPherson

app/controllers/publishers/vacancies/job_applications/online_checks_controller.rb

@@ -7,7 +7,7 @@ class OnlineChecksController < BaseController
         before_action :set_job_application
 
         def edit
-          @notes_form = Publishers::JobApplication::NotesForm.new
+          @note = @job_application.notes.build
         end
 
         def update

app/views/publishers/vacancies/job_applications/online_checks/edit.html.slim

@@ -23,5 +23,4 @@
       = f.govuk_submit t(".save_and_update")
 
   .govuk-grid-column-one-third
-    = render PublisherNotesOnJobApplicationComponent.new(job_application: @job_application, vacancy: @vacancy, notes_form: @notes_form,
-            return_to_url: edit_organisation_job_job_application_online_checks_path(@vacancy.id, @job_application.id))
+    = job_application_notes(job_application: @job_application, vacancy: @vacancy, note: @note, return_to_url: edit_organisation_job_job_application_online_checks_path(@vacancy.id, @job_application.id))

spec/system/publishers/publishers_can_select_a_job_application_for_interview_spec.rb

@@ -185,7 +185,7 @@
                   .to contain_exactly("employer@contoso.com", "previous@contoso.com")
 
                 expect(publisher_ats_pre_interview_checks_page).to be_displayed
-                # This now includes the self disclosure
+                # This count includes 2 references, the self disclosure and online checks
                 expect(publisher_ats_pre_interview_checks_page.reference_links.count).to eq(4)
                 publisher_ats_pre_interview_checks_page.reference_links.first.click