Skip to content

Commit fb169d2

Browse files
Filter email within args (#8561)
## Trello card URL https://trello.com/c/RJSX1Mb2/2655-user-emails-leaking-into-our-logs ## Changes in this PR: This change aims to stop the jobseeker email address leaking into the logs when job alerts get sent. The issue was that while the email and the mailer.to were already being filtered, when email was nested in the args it was not being filtered. This change should fix that. ## Screenshots of UI changes: ### Before ### After ## Checklists: ### Data & Schema Changes If this PR modifies data structures or validations, check the following: - [ ] Adds/removes model validations - [ ] Adds/removes database fields - [ ] Modifies Vacancy enumerables (phases, working patterns, job roles, key stages, etc.) <details> <summary>If any of the above options has changed then the author must check/resolve all of the following...</summary> ### Integration Impact Does this change affect any of these integrations? - [ ] DfE Analytics platform - [ ] Legacy imports mappings - [ ] DWP Find a Job export mappings - [ ] Publisher ATS API (may require mapping updates or API versioning) ### User Experience & Data Integrity Could this change impact: - [ ] Existing subscription alerts (will legacy subscription search filters break?) - [ ] Legacy vacancy copying (will copied vacancies fail new validations?) - [ ] In-progress drafts for Vacancies or Job Applications </details>
1 parent 3c32d48 commit fb169d2

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

config/initializers/filter_parameter_logging.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@
103103
unable_to_undertake_reason
104104
] + [
105105
/^age$/i,
106+
/args.*email/i,
106107
]
107108

108109
Rails.application.config.filter_parameters += MAILER_SANITIZED_PARAMS

0 commit comments

Comments
 (0)