`stockpiles`: furniture settings are not being serialized or deserialized properly

[ignomen]

Steam v52.03

I can export and import stockpile settings just fine, except when I try to name the settings prefaced with an underscore. Examples: _barrels, or _bins. The settings will export as a file, but when I import said file, the settings aren't properly carried over. In the case of a stockpile with only barrels of all materials and qualities, when importing, the stockpile setting will change to only Anvils (of all materials and qualities) instead. The same for bins. Notably Anvils is at the top of the list alphabetically, though I'm not sure if this is relevant.

I am not sure if a similar effect can be achieved with other characters but if requested I will check.
I did try re-loading the save and got the same result when importing, so I think it's reasonable to say its reproducibility is every time.

[ab9rf]

On investigation, the filename is irrelevant and the problem is that furniture stockpile settings are not being properly serialized and/or deserialized; more investigation is required to determine which

[ab9rf]

On further investigation, I have determined that this was working correctly in 50.15 but not in 51.13. Will continue to bisect to find the point at which it stopped working.

Update: 51.06-r2rc1 works correctly, 51.11-r1 does not. I don't have local builds for 51.07, 51.08, or 51.09 and my 51.10 build is actually a prerelease for 51.11 (and exhibits the misbehavior), which pins down the defect as being introduced between february 28 and april 21 of 2025.

[ab9rf]

Looks to be 6d9cfda

[ab9rf]

Ok, figured this one out:

In the Great Reorganization, the stockpile enums were redefined to match Bay12. For all but furniture (as far as I can tell), this had no effect, but for furniture this resulted in a "NONE" (-1) entry being added. This introduced an off-by-one error in both the serializer and deserializer that only affected furniture stockpiles; see #5275. @myk002 adjusted the deserializer to fix the off-by-one error in Dreamfort's saved stockpile settings, but did not fix the exporter at the same time; see #5377.

Applying the same fix from #5377 made for the deserializer to the serializer should resolve this issue. Stockpile presets exported between 51.07 and whenever this fix is committed will be broken for furniture; unfortunately, there's no easy way to fix this as dfstock files don't have generation numbers or record the version of DF or DFHack that was used to create them.