Fix the suspendmanager overlay appearing for followed units #5695
+28
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plule
force-pushed
the
fix-follow-overlay
branch
from
3f92791 to
9560cef
Compare
Member
|
I get the feeling that we need to rethink some aspect of the API here, but I am not going to delay implementing this while we do that. |
Contributor
Author
@ab9rf yes, in a way "getSelectedJob()" being too smart makes it hard to rely on. Maybe more spécialized versions of it would be better ("getSelectedBuildingJob()"/"getSelectedUnitJob()"). I'll give it a shot someday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suspendmanager overlay was relying on
dfhack.gui.getSelectedJob(), which looks for a job not only in buildings but also selected or followed units.Relying on the selected building instead removes these edge cases.
getSelectedJob also prioritize the followed unit over the selected building, but reversing this is not sufficient for cases where the building does not have any job.
Fixes #5681
Fixes #5439