Merge pull request #298 from DFiantHDL/opsrefactor

Reenable nvc and verilator tests after upstream fixes

Author: soronpo

.github/workflows/build.yml

@@ -37,10 +37,10 @@ jobs:
           apps: sbt bloop
       - name: Setup All Simulation Tools but NVC
         uses: YosysHQ/setup-oss-cad-suite@v3
-      - name: Setup Homebrew (for NVC)
-        uses: Homebrew/actions/setup-homebrew@master
       - name: Setup NVC
-        run: brew install nvc
+        uses: nickg/setup-nvc@v1
+        with:
+          version: latest
       - run: |
           verilator -version
           iverilog -V

lib/src/test/scala/util/FullCompileSpec.scala

@@ -50,16 +50,9 @@ abstract class FullCompileSpec extends FunSuite:
     given options.CompilerOptions.Backend = backends.verilog.v2001
     dut.compile.lintVerilog
 
-  // TODO: restore verilator when https://github.com/verilator/verilator/issues/6492
-  // is fixed
   test("verilog.v95 compilation with no error"):
     given options.CompilerOptions.Backend = backends.verilog.v95
-    val cd = dut.compile
-    List(iverilog, vlog, xvlog).foreach { linter =>
-      if (linter.isAvailable)
-        given LinterOptions.VerilogLinter = linter
-        cd.lint
-    }
+    dut.compile.lintVerilog
 
   test("vhdl[default = v2008] compilation with no error"):
     given options.CompilerOptions.Backend = backends.vhdl

project/DFHDLCommands.scala

@@ -115,13 +115,12 @@ object DFHDLCommands {
     state
   }
 
-  // TODO: restore nvc when https://github.com/nickg/nvc/issues/1306 is fixed
-  val vhdlTools = List("ghdl", "questa", "vivado")
+  val vhdlTools = List("ghdl", "nvc", "questa", "vivado")
   val verilogTools = List("verilator", "iverilog", "questa", "vivado")
   val vhdlDialects = List("vhdl.v93", "vhdl.v2008")
   val verilogDialects = List("verilog.v95", "verilog.v2001", "verilog.sv2005")
   // Skip tests that are known to fail because of the tool
-  val skip = Set(("verilator", "verilog.v95"), ("iverilog", "verilog.sv2005"), ("vivado", "vhdl.v2008"))
+  val skip = Set(("iverilog", "verilog.sv2005"), ("vivado", "vhdl.v2008"))
 
   val testApps = Command.command("testApps") { state =>
     var newState = Command.process("clearSandbox", state, _ => ())