Merge pull request #88 from DGouron/fix/optional-usernames-english-skills

fix(config): allow empty usernames for single-platform users

Author: DGouron

src/frameworks/config/configLoader.ts

@@ -115,7 +115,7 @@ function enrichRepository(input: RepositoryInput): RepositoryConfig | null {
   };
 }
 
-function validateAndEnrichConfig(data: unknown): Config {
+export function validateAndEnrichConfig(data: unknown): Config {
   if (!data || typeof data !== 'object') {
     throw new Error('Configuration invalide : objet attendu');
   }
@@ -136,11 +136,11 @@ function validateAndEnrichConfig(data: unknown): Config {
     throw new Error('Configuration invalide : section "user" manquante');
   }
   const user = config.user as Record<string, unknown>;
-  if (typeof user.gitlabUsername !== 'string' || !user.gitlabUsername) {
-    throw new Error('Configuration invalide : gitlabUsername manquant');
+  if (typeof user.gitlabUsername !== 'string') {
+    throw new Error('Invalid configuration: gitlabUsername must be a string');
   }
-  if (typeof user.githubUsername !== 'string' || !user.githubUsername) {
-    throw new Error('Configuration invalide : githubUsername manquant');
+  if (typeof user.githubUsername !== 'string') {
+    throw new Error('Invalid configuration: githubUsername must be a string');
   }
 
   // Validate queue

src/tests/units/frameworks/config/configLoader.test.ts

@@ -0,0 +1,97 @@
+import { validateAndEnrichConfig } from '../../../../frameworks/config/configLoader.js'
+
+function createValidConfig(userOverrides: Record<string, unknown> = {}) {
+  return {
+    server: { port: 3000 },
+    user: {
+      gitlabUsername: 'my-gitlab-user',
+      githubUsername: 'my-github-user',
+      ...userOverrides,
+    },
+    queue: { maxConcurrent: 2, deduplicationWindowMs: 5000 },
+    repositories: [],
+  }
+}
+
+describe('validateAndEnrichConfig', () => {
+  describe('username validation', () => {
+    it('should accept both non-empty usernames', () => {
+      const config = createValidConfig()
+
+      const result = validateAndEnrichConfig(config)
+
+      expect(result.user.gitlabUsername).toBe('my-gitlab-user')
+      expect(result.user.githubUsername).toBe('my-github-user')
+    })
+
+    it('should accept empty gitlabUsername with non-empty githubUsername', () => {
+      const config = createValidConfig({
+        gitlabUsername: '',
+        githubUsername: 'my-github-user',
+      })
+
+      const result = validateAndEnrichConfig(config)
+
+      expect(result.user.gitlabUsername).toBe('')
+      expect(result.user.githubUsername).toBe('my-github-user')
+    })
+
+    it('should accept empty githubUsername with non-empty gitlabUsername', () => {
+      const config = createValidConfig({
+        gitlabUsername: 'my-gitlab-user',
+        githubUsername: '',
+      })
+
+      const result = validateAndEnrichConfig(config)
+
+      expect(result.user.gitlabUsername).toBe('my-gitlab-user')
+      expect(result.user.githubUsername).toBe('')
+    })
+
+    it('should accept both usernames empty', () => {
+      const config = createValidConfig({
+        gitlabUsername: '',
+        githubUsername: '',
+      })
+
+      const result = validateAndEnrichConfig(config)
+
+      expect(result.user.gitlabUsername).toBe('')
+      expect(result.user.githubUsername).toBe('')
+    })
+
+    it('should reject non-string gitlabUsername', () => {
+      const config = createValidConfig({ gitlabUsername: 123 })
+
+      expect(() => validateAndEnrichConfig(config)).toThrow(
+        'gitlabUsername',
+      )
+    })
+
+    it('should reject missing gitlabUsername field', () => {
+      const config = createValidConfig()
+      ;(config.user as Record<string, unknown>).gitlabUsername = undefined
+
+      expect(() => validateAndEnrichConfig(config)).toThrow(
+        'gitlabUsername',
+      )
+    })
+
+    it('should reject non-string githubUsername', () => {
+      const config = createValidConfig({ githubUsername: true })
+
+      expect(() => validateAndEnrichConfig(config)).toThrow(
+        'githubUsername',
+      )
+    })
+
+    it('should reject missing githubUsername field', () => {
+      const config = createValidConfig()
+      ;(config.user as Record<string, unknown>).githubUsername = undefined
+
+      expect(() => validateAndEnrichConfig(config)).toThrow(
+        'githubUsername',
+      )
+    })
+  })
+})

src/tests/units/interface-adapters/controllers/webhook/eventFilter.test.ts

@@ -11,6 +11,7 @@ vi.mock('../../../../../config/loader.js', () => ({
   })),
 }))
 
+import { loadConfig } from '../../../../../config/loader.js'
 import {
   filterGitLabEvent,
   filterGitLabMrUpdate,
@@ -485,6 +486,32 @@ describe('filterGitHubLabelEvent', () => {
   })
 })
 
+describe('filterGitLabEvent with empty gitlabUsername', () => {
+  it('should not process when gitlabUsername is empty', () => {
+    vi.mocked(loadConfig).mockReturnValueOnce({
+      user: { gitlabUsername: '', githubUsername: 'claude-reviewer' },
+    } as ReturnType<typeof loadConfig>)
+    const event = GitLabEventFactory.createWithReviewerAdded('claude-reviewer')
+
+    const result = filterGitLabEvent(event)
+
+    expect(result.shouldProcess).toBe(false)
+  })
+})
+
+describe('filterGitHubEvent with empty githubUsername', () => {
+  it('should not process when githubUsername is empty', () => {
+    vi.mocked(loadConfig).mockReturnValueOnce({
+      user: { gitlabUsername: 'claude-reviewer', githubUsername: '' },
+    } as ReturnType<typeof loadConfig>)
+    const event = GitHubEventFactory.createReviewRequestedPr('claude-reviewer')
+
+    const result = filterGitHubEvent(event)
+
+    expect(result.shouldProcess).toBe(false)
+  })
+})
+
 describe('FilterResult type narrowing', () => {
   it('should have all required fields when shouldProcess is true', () => {
     const event = GitHubEventFactory.createReviewRequestedPr('claude-reviewer')