Merge pull request #85 from DGouron/fix/followup-score-boost

DGouron · web-flow · commit cb8f5723e418 · 2026-02-12T23:25:56.000+01:00
fix(tracking): remove averageScore, use latestScore for MR cards
diff --git a/.gitignore b/.gitignore
@@ -37,7 +37,6 @@ coverage/
 logs/security/
 .claude/skills
 .claude/memory
-.claude/backlog
 CLAUDE.md
 
 # MCP config (auto-generated by ensureProjectMcpConfig)
diff --git a/docs/architecture/mcp/architecture.md b/docs/architecture/mcp/architecture.md
@@ -156,4 +156,4 @@ yarn add @modelcontextprotocol/sdk
 
 ## Next Steps
 
-See tickets in `.claude/backlog/tickets/`
+See [GitHub Issues](https://github.com/DGouron/review-flow/issues) and the [ReviewFlow Roadmap](https://github.com/users/DGouron/projects/3) project board.
diff --git a/src/entities/tracking/trackedMr.ts b/src/entities/tracking/trackedMr.ts
@@ -31,7 +31,6 @@ export interface TrackedMr {
   totalWarnings: number;
   totalSuggestions: number;
   totalDurationMs: number;
-  averageScore: number | null;
   latestScore: number | null;
 
   autoFollowup: boolean;
diff --git a/src/frameworks/claude/claudeInvoker.ts b/src/frameworks/claude/claudeInvoker.ts
@@ -490,18 +490,19 @@ export async function invokeClaudeReview(
           outputLength: stdout.length,
         });
 
-        // Save review statistics
-        try {
-          // Look up assignor from MR tracking
-          const mrId = `${job.platform}-${job.projectPath}-${job.mrNumber}`;
-          const trackingGateway = new FileSystemReviewRequestTrackingGateway(new ProjectStatsCalculator());
-          const mrDetails = trackingGateway.getById(job.localPath, mrId);
-          const assignedBy = mrDetails?.assignment?.username;
-
-          const reviewStats = addReviewStats(job.localPath, job.mrNumber, durationMs, stdout, assignedBy);
-          logger.info({ reviewStats }, 'Stats de review enregistrées');
-        } catch (statsError) {
-          logger.warn({ error: statsError }, 'Erreur lors de l\'enregistrement des stats');
+        // Save review statistics (followups are not counted as reviews)
+        if (job.jobType !== 'followup') {
+          try {
+            const mrId = `${job.platform}-${job.projectPath}-${job.mrNumber}`;
+            const trackingGateway = new FileSystemReviewRequestTrackingGateway(new ProjectStatsCalculator());
+            const mrDetails = trackingGateway.getById(job.localPath, mrId);
+            const assignedBy = mrDetails?.assignment?.username;
+
+            const reviewStats = addReviewStats(job.localPath, job.mrNumber, durationMs, stdout, assignedBy);
+            logger.info({ reviewStats }, 'Stats de review enregistrées');
+          } catch (statsError) {
+            logger.warn({ error: statsError }, 'Erreur lors de l\'enregistrement des stats');
+          }
         }
         // Log stdout preview for debugging
         if (stdout.length > 0) {
diff --git a/src/interface-adapters/views/dashboard/index.html b/src/interface-adapters/views/dashboard/index.html
@@ -844,7 +844,7 @@ <h1>Reviewflow</h1>
       if (mr.totalBlocking > 0) statsBadges.push(`<span class="stat-badge blocking"><i data-lucide="octagon-alert"></i> ${mr.totalBlocking}</span>`);
       if (mr.totalWarnings > 0) statsBadges.push(`<span class="stat-badge warning"><i data-lucide="alert-triangle"></i> ${mr.totalWarnings}</span>`);
       if (mr.totalFollowups > 0) statsBadges.push(`<span class="stat-badge followup"><i data-lucide="refresh-cw"></i> ${mr.totalFollowups}</span>`);
-      if (mr.averageScore !== null) statsBadges.push(`<span class="stat-badge score"><i data-lucide="star"></i> ${mr.averageScore.toFixed(1)}/10</span>`);
+      if (mr.latestScore !== null) statsBadges.push(`<span class="stat-badge score"><i data-lucide="star"></i> ${mr.latestScore.toFixed(1)}/10</span>`);
 
       const durationFormatted = mr.totalDurationMs ? formatDuration(null, null, mr.totalDurationMs) : '';
 
diff --git a/src/tests/factories/trackedMr.factory.ts b/src/tests/factories/trackedMr.factory.ts
@@ -28,7 +28,6 @@ export class TrackedMrFactory {
       totalWarnings: 0,
       totalSuggestions: 0,
       totalDurationMs: 0,
-      averageScore: null,
       latestScore: null,
       autoFollowup: true,
       ...overrides,
diff --git a/src/tests/units/usecases/tracking/recordReviewCompletion.usecase.test.ts b/src/tests/units/usecases/tracking/recordReviewCompletion.usecase.test.ts
@@ -31,7 +31,6 @@ describe('RecordReviewCompletionUseCase', () => {
     expect(result?.totalSuggestions).toBe(1);
     expect(result?.totalDurationMs).toBe(60000);
     expect(result?.latestScore).toBe(8);
-    expect(result?.averageScore).toBe(8);
   });
 
   it('should transition to pending-fix when blocking issues exist', () => {
@@ -80,12 +79,31 @@ describe('RecordReviewCompletionUseCase', () => {
     expect(result?.totalThreads).toBe(3);
   });
 
-  it('should compute average score across reviews', () => {
+  it('should record followup type separately', () => {
+    const gateway = new InMemoryReviewRequestTrackingGateway();
+    const mr = TrackedMrFactory.create({ id: 'mr-1' });
+    gateway.create('/project', mr);
+    const useCase = new RecordReviewCompletionUseCase(gateway);
+
+    const result = useCase.execute({
+      projectPath: '/project',
+      mrId: 'mr-1',
+      reviewData: { ...reviewData, type: 'followup' },
+    });
+
+    expect(result?.totalFollowups).toBe(1);
+    expect(result?.totalReviews).toBe(0);
+  });
+
+  it('should set latestScore to the most recent review score', () => {
     const gateway = new InMemoryReviewRequestTrackingGateway();
     const mr = TrackedMrFactory.create({
       id: 'mr-1',
-      reviews: [{ type: 'review', timestamp: '2024-01-01T00:00:00Z', durationMs: 1000, score: 6, blocking: 0, warnings: 0, suggestions: 0, threadsClosed: 0, threadsOpened: 0 }],
+      reviews: [
+        { type: 'review', timestamp: '2024-01-01T00:00:00Z', durationMs: 1000, score: 6, blocking: 0, warnings: 0, suggestions: 0, threadsClosed: 0, threadsOpened: 0 },
+      ],
       totalReviews: 1,
+      latestScore: 6,
     });
     gateway.create('/project', mr);
     const useCase = new RecordReviewCompletionUseCase(gateway);
@@ -96,24 +114,39 @@ describe('RecordReviewCompletionUseCase', () => {
       reviewData: { ...reviewData, score: 10 },
     });
 
-    expect(result?.averageScore).toBe(8);
     expect(result?.latestScore).toBe(10);
   });
 
-  it('should record followup type separately', () => {
+  it('should update latestScore from followup', () => {
     const gateway = new InMemoryReviewRequestTrackingGateway();
-    const mr = TrackedMrFactory.create({ id: 'mr-1' });
+    const mr = TrackedMrFactory.create({
+      id: 'mr-1',
+      reviews: [
+        { type: 'review', timestamp: '2024-01-01T00:00:00Z', durationMs: 1000, score: 5, blocking: 1, warnings: 0, suggestions: 0, threadsClosed: 0, threadsOpened: 1 },
+      ],
+      totalReviews: 1,
+      latestScore: 5,
+      openThreads: 1,
+      totalThreads: 1,
+    });
     gateway.create('/project', mr);
     const useCase = new RecordReviewCompletionUseCase(gateway);
 
     const result = useCase.execute({
       projectPath: '/project',
       mrId: 'mr-1',
-      reviewData: { ...reviewData, type: 'followup' },
+      reviewData: {
+        type: 'followup',
+        durationMs: 30000,
+        score: 8,
+        blocking: 0,
+        warnings: 0,
+        suggestions: 0,
+        threadsClosed: 1,
+      },
     });
 
-    expect(result?.totalFollowups).toBe(1);
-    expect(result?.totalReviews).toBe(0);
+    expect(result?.latestScore).toBe(8);
   });
 
   it('should return null for unknown MR', () => {
diff --git a/src/usecases/tracking/recordReviewCompletion.usecase.ts b/src/usecases/tracking/recordReviewCompletion.usecase.ts
@@ -56,19 +56,12 @@ export class RecordReviewCompletionUseCase implements UseCase<RecordReviewComple
       latestScore = reviewData.score;
     }
 
-    const reviewsWithScore = afterEvent.reviews.filter((r) => r.score !== null);
-    let averageScore: number | null = null;
-    if (reviewsWithScore.length > 0) {
-      averageScore = reviewsWithScore.reduce((sum, r) => sum + (r.score ?? 0), 0) / reviewsWithScore.length;
-    }
-
     const hasBlockingIssues = reviewData.blocking > 0 || openThreads > 0;
 
     this.trackingGateway.update(projectPath, mrId, {
       openThreads,
       totalThreads,
       latestScore,
-      averageScore,
       state: hasBlockingIssues ? 'pending-fix' : 'pending-approval',
     });
 
diff --git a/src/usecases/tracking/trackAssignment.usecase.ts b/src/usecases/tracking/trackAssignment.usecase.ts
@@ -93,7 +93,6 @@ export class TrackAssignmentUseCase implements UseCase<TrackAssignmentInput, Tra
       totalWarnings: 0,
       totalSuggestions: 0,
       totalDurationMs: 0,
-      averageScore: null,
       latestScore: null,
       autoFollowup: true,
     };

Original file line number	Diff line number	Diff line change
`@@ -156,4 +156,4 @@ yarn add @modelcontextprotocol/sdk`
`156`	`156`
`157`	`157`	`## Next Steps`
`158`	`158`
`159`		-See tickets in `.claude/backlog/tickets/`
	`159`	`+See [GitHub Issues](https://github.com/DGouron/review-flow/issues) and the [ReviewFlow Roadmap](https://github.com/users/DGouron/projects/3) project board.`