Skip to content

Commit 27f2f18

Browse files
committed
fix: printouts: from kB to MB
1 parent ea2b445 commit 27f2f18

File tree

1 file changed

+13
-12
lines changed
  • src/DIRAC/WorkloadManagementSystem/JobWrapper

1 file changed

+13
-12
lines changed

src/DIRAC/WorkloadManagementSystem/JobWrapper/Watchdog.py

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -284,11 +284,12 @@ def _performChecks(self):
284284
result = self.profiler.memoryUsage(withChildren=True)
285285
if not result["OK"]:
286286
self.log.warn("Could not get rss info from profiler", result["Message"])
287-
msg += f"MemUsed: {result['Value']:.1f} kb "
288-
heartBeatDict["MemoryUsed"] = result["Value"]
289-
if "MemoryUsed" not in self.parameters:
290-
self.parameters["MemoryUsed"] = []
291-
self.parameters["MemoryUsed"].append(result["Value"])
287+
else:
288+
msg += f"MemUsed: {result['Value']:.1f} MB "
289+
heartBeatDict["MemoryUsed"] = result["Value"]
290+
if "MemoryUsed" not in self.parameters:
291+
self.parameters["MemoryUsed"] = []
292+
self.parameters["MemoryUsed"].append(result["Value"])
292293

293294
result = self.profiler.vSizeUsage(withChildren=True)
294295
if not result["OK"]:
@@ -298,7 +299,7 @@ def _performChecks(self):
298299
heartBeatDict["Vsize"] = vsize
299300
self.parameters.setdefault("Vsize", [])
300301
self.parameters["Vsize"].append(vsize)
301-
msg += f"Job Vsize: {vsize:.1f} kb "
302+
msg += f"Job Vsize: {vsize:.1f} MB "
302303

303304
if "DiskSpace" not in self.parameters:
304305
self.parameters["DiskSpace"] = []
@@ -652,7 +653,7 @@ def __checkMemoryLimit(self):
652653
if vsize and self.memoryLimit:
653654
if vsize > self.memoryLimit:
654655
# Just a warning for the moment
655-
self.log.warn(f"Job has consumed {vsize:f}.2 KB of memory with the limit of {self.memoryLimit:f}.2 KB")
656+
self.log.warn(f"Job has consumed {vsize:f}.2 MB of memory with the limit of {self.memoryLimit:f}.2 MB")
656657

657658
return S_OK()
658659

@@ -736,15 +737,15 @@ def calibrate(self):
736737
else:
737738
vsize = result["Value"] * 1024.0
738739
self.initialValues["Vsize"] = vsize
739-
self.log.verbose("Vsize(kb)", f"{vsize:.1f}")
740+
self.log.verbose("Vsize(MB)", f"{vsize:.1f}")
740741
self.parameters["Vsize"] = []
741742

742743
result = self.profiler.memoryUsage(withChildren=True)
743744
if not result["OK"]:
744745
self.log.warn("Could not get rss info from profiler", result["Message"])
745746
else:
746747
self.initialValues["RSS"] = result["Value"]
747-
self.log.verbose("RSS(mb)", f"{result['Value']:.1f}")
748+
self.log.verbose("RSS(MB)", f"{result['Value']:.1f}")
748749
self.parameters["RSS"] = []
749750

750751
# We exclude fuse so that mountpoints can be cleaned up by automount after a period unused
@@ -827,9 +828,9 @@ def __getUsageSummary(self):
827828
if "MemoryUsed" in self.parameters:
828829
memory = self.parameters["MemoryUsed"]
829830
if memory:
830-
summary["MemoryUsed(kb)"] = abs(float(memory[-1]) - float(self.initialValues["MemoryUsed"]))
831+
summary["MemoryUsed(MB)"] = abs(float(memory[-1]) - float(self.initialValues["MemoryUsed"]))
831832
else:
832-
summary["MemoryUsed(kb)"] = math.nan
833+
summary["MemoryUsed(MB)"] = math.nan
833834
# LoadAverage
834835
if "LoadAverage" in self.parameters:
835836
laList = self.parameters["LoadAverage"]
@@ -936,7 +937,7 @@ def getNodeInformation(self):
936937
"""Retrieves all static system information"""
937938
result = {}
938939
result["HostName"] = socket.gethostname()
939-
result["Memory(kB)"] = int(psutil.virtual_memory()[1] / 1024)
940+
result["Memory(MB)"] = int(psutil.virtual_memory()[1] / 1024 / 1024)
940941
result["LocalAccount"] = getpass.getuser()
941942

942943
path = Path("/proc/cpuinfo")

0 commit comments

Comments
 (0)