You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/CONTRIBUTING.md
+8-5Lines changed: 8 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,7 +1,6 @@
1
1
2
2
# Contribution Guidelines for DIRAC
3
3
4
-
5
4
## Pull Requests
6
5
7
6
When making a `Pull Request` please explain what and why things were
@@ -12,7 +11,7 @@ relase.notes, once a new tag is made.
12
11
Please prepend the title of your pull request with `[targetReleaseBranch]`.
13
12
14
13
We are happy if you create pull-requests also if you feature is not ready, yet.
15
-
Please mark them as such by adding `[WIP]` to the start of the title. The purpose
14
+
Please mark them as drafts in this case. The purpose
16
15
of this is, for example, that you want to let other people know you are working
17
16
on a given issue. For these work-in-progress pull-request, we propose to have a
18
17
check list of things that still need to be done.
@@ -24,9 +23,13 @@ If you notice an issue, consider first creating an issue and then refering to it
24
23
in your pull-request and commit messages with `#[issue-id]`.
25
24
26
25
## Coding Conventions
27
-
* You should follow the [DIRAC Coding Conventions](https://dirac.readthedocs.io/en/latest/DeveloperGuide/CodingConvention/index.html)
28
-
* Your code should not introduce any new pylint warnings, and fix as many existing warnings as possible
26
+
27
+
* You should follow the [DIRAC Coding Conventions](https://dirac.readthedocs.io/en/latest/DeveloperGuide/CodingConvention/index.html)
28
+
* Your code should not introduce any new pylint warnings, and fix as many existing warnings as possible
29
29
30
30
## Git workflow
31
31
32
-
The DIRAC Development Model is described in the [documentation](https://dirac.readthedocs.io/en/latest/DeveloperGuide/DevelopmentModel/index.html) with detailed instructions on the git workflow listed [here](https://dirac.readthedocs.io/en/latest/DeveloperGuide/DevelopmentModel/ContributingCode/index.html). For additional help on the git(hub) workflow please see this [tutorial](https://github.com/andresailer/tutorial#working-updating-pushing).
32
+
The DIRAC Development Model is described in the [documentation](https://dirac.readthedocs.io/en/latest/DeveloperGuide/DevelopmentModel/index.html) with detailed instructions on the git workflow listed [here](https://dirac.readthedocs.io/en/latest/DeveloperGuide/DevelopmentModel/ContributingCode/index.html). For additional help on the git(hub) workflow please see this [tutorial](https://github.com/andresailer/tutorial#working-updating-pushing).
33
+
34
+
Open a pull request only for the target branch. The [PR Sweeper](https://github.com/DIRACGrid/pr-sweeper) will (try to) create a PR for the "upper" branches.
35
+
If failing to do so, an issue will be created and assigned to the PR opener.
0 commit comments