fix: Fixed ClientSelector to raise an error if the CS is badly configured

Author: Robin-Van-de-Merghel

integration_tests.py

@@ -43,7 +43,7 @@
 # All services that have a FutureClient, but we *explicitly* deactivate
 # (for example if we did not finish to develop it)
 DIRACX_DISABLED_SERVICES = [
-    # "WorkloadManagement/JobMonitoring",
+    "WorkloadManagement/JobMonitoring",
 ]
 
 # Static configuration

src/DIRAC/Core/Tornado/Client/ClientSelector.py

@@ -81,6 +81,10 @@ def ClientSelector(disetClient, *args, **kwargs):  # We use same interface as RP
             rpc = tornadoClient(*args, **kwargs)
         else:
             rpc = disetClient(*args, **kwargs)
+    except NotImplementedError as e:
+        # We catch explicitly NotImplementedError to avoid just printing "there's an error"
+        # If we mis-configured the CS for legacy adapted services, we MUST have an error.
+        raise e
     except Exception as e:  # pylint: disable=broad-except
         # If anything went wrong in the resolution, we return default RPCClient
         # So the behaviour is exactly the same as before implementation of Tornado

src/DIRAC/WorkloadManagementSystem/Client/JobMonitoringClient.py

@@ -14,6 +14,8 @@
 
 @createClient("WorkloadManagement/JobMonitoring")
 class JobMonitoringClient(Client):
+    # Set to None to raise an error if this service is set as "legacy adapted"
+    # See ClientSelector
     diracxClient = None
 
     def __init__(self, **kwargs):