sweep: #6442 Add mypy CI job

Author: chrisburr

.github/workflows/basic.yml

@@ -71,6 +71,7 @@ jobs:
           #     DISET's string and unicode types being poorly defined
           - pytest --runslow -k 'not test_BaseType_Unicode and not test_nestedStructure'
           - pylint -E src/
+          - mypy
 
     steps:
     - uses: actions/checkout@v2

environment.yml

@@ -91,13 +91,20 @@ dependencies:
   - typing >=3.6.6
   - pyyaml
   - rucio-clients
+  # For mypy
+  - mypy >=0.982
+  - types-cachetools
+  - types-python-dateutil
+  - types-pytz
+  - types-PyYAML
+  - types-requests
+  - types-setuptools
   - pip:
     # Prerelease of the required package for integration of OAuth2
     - Authlib>=1.0.0.a2
     - dominate
     - pyjwt
     # This is a fork of tornado with a patch to allow for configurable iostream
-    # It should eventually be part of DIRACGrid
     - git+https://github.com/DIRACGrid/tornado.git@iostreamConfigurable
     # This is an extension of Tornado to use M2Crypto
     # It should eventually be part of DIRACGrid

pyproject.toml

@@ -21,6 +21,10 @@ allow_redefinition = true
 strict = true
 check_untyped_defs = true
 ignore_missing_imports = true
+files = [
+    'src/DIRAC/Core/Utilities/ReturnValues.py',
+    'src/DIRAC/Core/Security/Properties.py'
+]
 exclude = [
     '/tests/'
 ]

src/DIRAC/Core/Security/Properties.py

@@ -5,7 +5,7 @@
 
 import operator
 from enum import Enum
-from typing import Union
+from typing import Callable, Union
 
 
 class SecurityProperty(str, Enum):
@@ -94,7 +94,7 @@ def __str__(self) -> str:
     def __repr__(self) -> str:
         return repr(self.property)
 
-    def __call__(self, allowed_properties: list[SecurityProperty]):
+    def __call__(self, allowed_properties: list[SecurityProperty]) -> bool:
         return self.property in allowed_properties
 
     def __and__(self, value: UnevaluatedProperty) -> UnevaluatedExpression:
@@ -111,7 +111,7 @@ def __invert__(self) -> UnevaluatedExpression:
 
 
 class UnevaluatedExpression(UnevaluatedProperty):
-    def __init__(self, operator: callable, *args: list[UnevaluatedProperty]):
+    def __init__(self, operator: Callable[..., bool], *args: UnevaluatedProperty):
         self.operator = operator
         self.args = args
 
@@ -128,7 +128,7 @@ def __str__(self) -> str:
     def __repr__(self) -> str:
         return f"{self.operator.__name__}({', '.join(map(repr, self.args))})"
 
-    def __call__(self, properties):
+    def __call__(self, properties: list[SecurityProperty]) -> bool:
         return self.operator(*(a(properties) for a in self.args))