fix: getJobParameters expects a list

Author: fstagni

src/DIRAC/WorkloadManagementSystem/Agent/StalledJobAgent.py

@@ -254,7 +254,7 @@ def _failStalledJobs(self, jobID):
 
     def _getJobPilotStatus(self, jobID):
         """Get the job pilot status."""
-        result = getJobParameters(jobID, "Pilot_Reference")
+        result = getJobParameters([jobID], "Pilot_Reference")
         if not result["OK"]:
             return result
         pilotReference = result["Value"].get("Pilot_Reference")
@@ -389,11 +389,11 @@ def _sendAccounting(self, jobID):
             if lastHeartBeatTime is not None and lastHeartBeatTime > endTime:
                 endTime = lastHeartBeatTime
 
-            result = getJobParameters(jobID, "CPUNormalizationFactor")
-            if not result["OK"] or not result["Value"]:
+            result = getJobParameters([jobID], "CPUNormalizationFactor")
+            if not result["OK"] or not result["Value"] or not result["Value"].get("CPUNormalizationFactor"):
                 self.log.error(
                     "Error getting Job Parameter CPUNormalizationFactor, setting 0",
-                    result.get("Message", "No such value"),
+                    result.get("Message"),
                 )
                 cpuNormalization = 0.0
             else:

src/DIRAC/WorkloadManagementSystem/DB/JobParametersDB.py

@@ -69,7 +69,7 @@ def _createIndex(self, indexName: str) -> None:
                 raise RuntimeError(result["Message"])
             self.log.always("Index created:", indexName)
 
-    def getJobParameters(self, jobIDs: int | list[int], vo: str, paramList=None) -> dict:
+    def getJobParameters(self, jobIDs: int | list[int], vo: str, paramList: list[str] | None = None) -> dict:
         """Get Job Parameters defined for jobID.
           Returns a dictionary with the Job Parameters.
           If paramList is empty - all the parameters are returned.

src/DIRAC/WorkloadManagementSystem/Service/JobMonitoringHandler.py

@@ -247,7 +247,7 @@ def export_getJobParameter(self, jobID, parName):
         :param str/int jobID: one single Job ID
         :param str parName: one single parameter name
         """
-        res = self.elasticJobParametersDB.getJobParameters(int(jobID), self.vo, [parName])
+        res = getJobParameters([int(jobID)], parName, self.vo or "")
         if not res["OK"]:
             return res
         return S_OK(res["Value"].get(int(jobID), {}))
@@ -266,7 +266,7 @@ def export_getJobOptParameters(cls, jobID):
     def export_getJobParameters(self, jobIDs, parName=None):
         """
         :param str/int/list jobIDs: one single job ID or a list of them
-        :param str parName: one single parameter name, a list or None (meaning all of them)
+        :param str parName: one single parameter name, or None (meaning all of them)
         """
         if not isinstance(jobIDs, list):
             jobIDs = [jobIDs]