fix (DMS): ReplicateAndRegister checks SE status even for FTS

Author: chaen

src/DIRAC/DataManagementSystem/Agent/FTS3Agent.py

@@ -169,7 +169,7 @@ def getFTS3Context(self, username, group, ftsServer, threadID):
 
             log.debug(f"UserDN {userDN}")
 
-            # Chose a meaningfull proxy name for easier debugging
+            # Chose a meaningful proxy name for easier debugging
             srvName = parse.urlparse(ftsServer).netloc.split(":")[0]
             proxyFile = os.path.join(
                 self.workDirectory, f"{int(time.time())}_{username}_{group}_{srvName}_{threadID}.pem"

src/DIRAC/DataManagementSystem/Agent/RequestOperations/ReplicateAndRegister.py

@@ -184,6 +184,35 @@ def __call__(self):
         if self.rmsMonitoring:
             self.rmsMonitoringReporter = MonitoringReporter(monitoringType="RMSMonitoring")
 
+        sourceSE = self.operation.SourceSE if self.operation.SourceSE else None
+        if sourceSE:
+            # check sourceSE for read
+            bannedSource = self.checkSEsRSS(sourceSE, "ReadAccess")
+            if not bannedSource["OK"]:
+                if self.rmsMonitoring:
+                    for status in ["Attempted", "Failed"]:
+                        self.rmsMonitoringReporter.addRecord(self.createRMSRecord(status, len(self.operation)))
+                    self.rmsMonitoringReporter.commit()
+                return bannedSource
+
+            if bannedSource["Value"]:
+                self.operation.Error = f"SourceSE {sourceSE} is banned for reading"
+                self.log.info(self.operation.Error)
+                return S_OK(self.operation.Error)
+
+        # check targetSEs for write
+        bannedTargets = self.checkSEsRSS()
+        if not bannedTargets["OK"]:
+            if self.rmsMonitoring:
+                for status in ["Attempted", "Failed"]:
+                    self.rmsMonitoringReporter.addRecord(self.createRMSRecord(status, len(self.operation)))
+                self.rmsMonitoringReporter.commit()
+            return bannedTargets
+
+        if bannedTargets["Value"]:
+            self.operation.Error = f"{','.join(bannedTargets['Value'])} targets are banned for writing"
+            return S_OK(self.operation.Error)
+
         # # check replicas first
         checkReplicas = self.__checkReplicas()
         if not checkReplicas["OK"]:
@@ -480,36 +509,6 @@ def fts3Transfer(self):
 
     def dmTransfer(self, fromFTS=False):
         """replicate and register using dataManager"""
-        # # get waiting files. If none just return
-        # # source SE
-        sourceSE = self.operation.SourceSE if self.operation.SourceSE else None
-        if sourceSE:
-            # # check source se for read
-            bannedSource = self.checkSEsRSS(sourceSE, "ReadAccess")
-            if not bannedSource["OK"]:
-                if self.rmsMonitoring:
-                    for status in ["Attempted", "Failed"]:
-                        self.rmsMonitoringReporter.addRecord(self.createRMSRecord(status, len(self.operation)))
-                    self.rmsMonitoringReporter.commit()
-                return bannedSource
-
-            if bannedSource["Value"]:
-                self.operation.Error = f"SourceSE {sourceSE} is banned for reading"
-                self.log.info(self.operation.Error)
-                return S_OK(self.operation.Error)
-
-        # # check targetSEs for write
-        bannedTargets = self.checkSEsRSS()
-        if not bannedTargets["OK"]:
-            if self.rmsMonitoring:
-                for status in ["Attempted", "Failed"]:
-                    self.rmsMonitoringReporter.addRecord(self.createRMSRecord(status, len(self.operation)))
-                self.rmsMonitoringReporter.commit()
-            return bannedTargets
-
-        if bannedTargets["Value"]:
-            self.operation.Error = f"{','.join(bannedTargets['Value'])} targets are banned for writing"
-            return S_OK(self.operation.Error)
 
         # Can continue now
         self.log.verbose("No targets banned for writing")