Skip to content

Commit 97fd32c

Browse files
authored
Merge pull request #6554 from DIRACGridBot/cherry-pick-2-0c896ea0d-integration
[sweep:integration] integration tests: simplifying finding release
2 parents 602d297 + 697e07e commit 97fd32c

File tree

2 files changed

+12
-16
lines changed

2 files changed

+12
-16
lines changed

integration_tests.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -537,14 +537,14 @@ def _check_containers_running(*, is_up=True):
537537
raise typer.Exit(code=1)
538538

539539

540-
def _find_dirac_release_and_branch():
540+
def _find_dirac_release():
541541
# Start by looking for the GitHub/GitLab environment variables
542-
ref = os.environ.get("CI_COMMIT_REF_NAME", os.environ.get("GITHUB_REF"))
543-
if ref == "refs/heads/integration":
544-
return "integration", ""
545-
ref = os.environ.get("CI_MERGE_REQUEST_TARGET_BRANCH_NAME", os.environ.get("GITHUB_BASE_REF"))
546-
if ref == "integration":
547-
return "integration", ""
542+
if "GITHUB_BASE_REF" in os.environ: # this will be "rel-v8r0"
543+
return os.environ["GITHUB_BASE_REF"]
544+
if "CI_COMMIT_REF_NAME" in os.environ:
545+
return os.environ["CI_COMMIT_REF_NAME"]
546+
if "CI_MERGE_REQUEST_TARGET_BRANCH_NAME" in os.environ:
547+
return os.environ["CI_MERGE_REQUEST_TARGET_BRANCH_NAME"]
548548

549549
repo = git.Repo(os.getcwd())
550550
# Try to make sure the upstream remote is up to date
@@ -577,9 +577,9 @@ def _find_dirac_release_and_branch():
577577
err=True,
578578
fg=c.YELLOW,
579579
)
580-
return "integration", ""
580+
return "integration"
581581
else:
582-
return "", f"v{version.major}r{version.minor}"
582+
return version_branch
583583

584584

585585
def _make_env(flags):
@@ -645,7 +645,9 @@ def _make_config(modules, flags, release_var, editable):
645645
if release_var:
646646
config |= dict([release_var.split("=", 1)])
647647
else:
648-
config["DIRAC_RELEASE"], config["DIRACBRANCH"] = _find_dirac_release_and_branch()
648+
config["DIRAC_RELEASE"] = _find_dirac_release()
649+
650+
print(config)
649651

650652
for key, default_value in FEATURE_VARIABLES.items():
651653
config[key] = flags.pop(key, default_value)

tests/Jenkins/dirac_ci.sh

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,6 @@ else
5858
WORKSPACE=$PWD
5959
fi
6060

61-
if [[ "$DIRACBRANCH" ]]; then
62-
echo "==> Working on DIRAC branch $DIRACBRANCH"
63-
else
64-
DIRACBRANCH='integration'
65-
fi
66-
6761
# Creating default structure
6862
mkdir -p "$WORKSPACE/TestCode" # Where the test code resides
6963
TESTCODE=${_}

0 commit comments

Comments
 (0)