fix: simplifying if statements for returning bools (anti-pattern)

Author: kreczko

src/DIRAC/ConfigurationSystem/private/ConfigurationData.py

@@ -249,17 +249,11 @@ def mergingEnabled(self):
 
     def getAutoPublish(self):
         value = self.extractOptionFromCFG("%s/AutoPublish" % self.configurationPath, self.localCFG)
-        if value and value.lower() in ("no", "false", "n"):
-            return False
-        else:
-            return True
+        return not bool(value and value.lower() in ("no", "false", "n"))
 
     def getAutoSlaveSync(self):
         value = self.extractOptionFromCFG("%s/AutoSlaveSync" % self.configurationPath, self.localCFG)
-        if value and value.lower() in ("no", "false", "n"):
-            return False
-        else:
-            return True
+        return not bool(value and value.lower() in ("no", "false", "n"))
 
     def getServers(self):
         return list(self.remoteServerList)
@@ -288,10 +282,7 @@ def getCompressedData(self):
 
     def isMaster(self):
         value = self.extractOptionFromCFG("%s/Master" % self.configurationPath, self.localCFG)
-        if value and value.lower() in ("yes", "true", "y"):
-            return True
-        else:
-            return False
+        return bool(value and value.lower() in ("yes", "true", "y"))
 
     def getServicesPath(self):
         return "/Services"
@@ -304,15 +295,11 @@ def isService(self):
 
     def useServerCertificate(self):
         value = self.extractOptionFromCFG("/DIRAC/Security/UseServerCertificate")
-        if value and value.lower() in ("y", "yes", "true"):
-            return True
-        return False
+        return bool(value and value.lower() in ("yes", "true", "y"))
 
     def skipCACheck(self):
         value = self.extractOptionFromCFG("/DIRAC/Security/SkipCAChecks")
-        if value and value.lower() in ("y", "yes", "true"):
-            return True
-        return False
+        return bool(value and value.lower() in ("yes", "true", "y"))
 
     def dumpLocalCFGToFile(self, fileName):
         try:

src/DIRAC/DataManagementSystem/Client/CmdDirCompletion/DirectoryCompletion.py

@@ -44,18 +44,13 @@ def parse_text_line(self, text, line, cwd):
 
     # check absolute path
     def check_absolute(self, path):
-        if path.startswith(self.fs.seq):
-            return True
-        else:
-            return False
+        return path.startswith(self.fs.seq)
 
     # generate absolute path
     def generate_absolute(self, path, cwd):
         if self.check_absolute(path):
-            pass
-        else:
-            path = os.path.join(cwd, path)
-        return path
+            return path
+        return os.path.join(cwd, path)
 
     # get the parent directory or the current directory
     # Using the last char "/" to determine