Skip to content

Commit b793732

Browse files
committed
fix: minor fixes to keep in 8.0
1 parent 89d1e3f commit b793732

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

src/DIRAC/WorkloadManagementSystem/Service/SandboxStoreHandler.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def initializeHandler(cls, serviceInfoDict):
4646
return S_ERROR(f"Can't connect to DB: {repr(excp)}")
4747
return S_OK()
4848

49-
def initialize(self):
49+
def initializeRequest(self):
5050
self.__backend = self.getCSOption("Backend", "local")
5151
self.__localSEName = self.getCSOption("LocalSE", "SandboxSE")
5252
self._maxUploadBytes = self.getCSOption("MaxSandboxSizeMiB", 10) * 1048576
@@ -64,9 +64,6 @@ def initialize(self):
6464
if SandboxStoreHandler.__purgeCount == 0:
6565
threading.Thread(target=self.purgeUnusedSandboxes).start()
6666

67-
def initializeRequest(self):
68-
self.initialize()
69-
7067
def __getSandboxPath(self, md5):
7168
"""Generate the sandbox path"""
7269
# prefix = self.getCSOption( "SandboxPrefix", "SandBox" )
@@ -364,7 +361,7 @@ def export_assignSandboxesToEntities(self, enDict, ownerName="", ownerGroup="",
364361
Expects a dict of { entityId : [ ( SB, SBType ), ... ] }
365362
"""
366363
if not entitySetup:
367-
entitySetup = self.serviceInfoDict["clientSetup"]
364+
entitySetup = self.diracSetup
368365
credDict = self.getRemoteCredentials()
369366
return self.sandboxDB.assignSandboxesToEntities(
370367
enDict, credDict["username"], credDict["group"], entitySetup, ownerName, ownerGroup
@@ -380,7 +377,7 @@ def export_unassignEntities(self, entitiesList, entitiesSetup=False):
380377
Unassign a list of jobs
381378
"""
382379
if not entitiesSetup:
383-
entitiesSetup = self.serviceInfoDict["clientSetup"]
380+
entitiesSetup = self.diracSetup
384381
credDict = self.getRemoteCredentials()
385382
return self.sandboxDB.unassignEntities({entitiesSetup: entitiesList}, credDict["username"], credDict["group"])
386383

@@ -394,7 +391,7 @@ def export_getSandboxesAssignedToEntity(self, entityId, entitySetup=False):
394391
Get the sandboxes associated to a job and the association type
395392
"""
396393
if not entitySetup:
397-
entitySetup = self.serviceInfoDict["clientSetup"]
394+
entitySetup = self.diracSetup
398395
credDict = self.getRemoteCredentials()
399396
result = self.sandboxDB.getSandboxesAssignedToEntity(
400397
entityId, entitySetup, credDict["username"], credDict["group"]
@@ -581,4 +578,7 @@ def __deleteSandboxFromExternalBackend(self, SEName, SEPFN):
581578

582579

583580
class SandboxStoreHandler(SandboxStoreHandlerMixin, RequestHandler):
584-
pass
581+
def initialize(self):
582+
# we need it still in 8.0
583+
self.diracSetup = self.serviceInfoDict["clientSetup"]
584+
return self.initializeRequest()

src/DIRAC/WorkloadManagementSystem/Service/TornadoSandboxStoreHandler.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414

1515
class TornadoSandboxStoreHandler(SandboxStoreHandlerMixin, TornadoService):
1616
def initializeRequest(self):
17+
self.diracSetup = self.get_argument("clientSetup")
18+
# Ugly, but makes DIPS and HTTPS handlers compatible, TBD properly
19+
self.serviceInfoDict = self._serviceInfoDict
1720
return SandboxStoreHandlerMixin.initializeRequest(self)
1821

1922
def export_streamFromClient(self, fileId, token, fileSize, data):

0 commit comments

Comments
 (0)