Skip to content

Commit e08076d

Browse files
authored
Merge pull request #6906 from fstagni/80_fixes51
[8.0] SiteDirector: failure in submitting Accounting or Monitoring report only prints an error
2 parents 02d16ec + 890b273 commit e08076d

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

src/DIRAC/WorkloadManagementSystem/Agent/SiteDirector.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -714,9 +714,8 @@ def _submitPilotsToQueue(self, pilotsToSubmit, ce, queue):
714714
:param str queue: queue where to submit
715715
716716
:return: S_OK/S_ERROR.
717-
If S_OK, returns tuple with (pilotsToSubmit, pilotList, stampDict)
717+
If S_OK, returns tuple with (pilotList, stampDict)
718718
where
719-
pilotsToSubmit is the pilots still to submit (maybe 0)
720719
pilotsList is the list of pilots submitted
721720
stampDict is a dict of timestamps of pilots submission
722721
:rtype: dict
@@ -752,7 +751,7 @@ def _submitPilotsToQueue(self, pilotsToSubmit, ce, queue):
752751
"Failed",
753752
)
754753
if not result["OK"]:
755-
return result
754+
self.log.error("Failure submitting Accounting report", result["Message"])
756755

757756
if self.sendSubmissionMonitoring:
758757
result = self.sendPilotSubmissionMonitoring(
@@ -764,7 +763,7 @@ def _submitPilotsToQueue(self, pilotsToSubmit, ce, queue):
764763
"Failed",
765764
)
766765
if not result["OK"]:
767-
return result
766+
self.log.error("Failure submitting Monitoring report", result["Message"])
768767

769768
self.failedQueues[queue] += 1
770769
return submitResult
@@ -788,7 +787,7 @@ def _submitPilotsToQueue(self, pilotsToSubmit, ce, queue):
788787
"Succeeded",
789788
)
790789
if not result["OK"]:
791-
return result
790+
self.log.error("Failure submitting Accounting report", result["Message"])
792791

793792
if self.sendSubmissionMonitoring:
794793
result = self.sendPilotSubmissionMonitoring(
@@ -800,7 +799,7 @@ def _submitPilotsToQueue(self, pilotsToSubmit, ce, queue):
800799
"Succeeded",
801800
)
802801
if not result["OK"]:
803-
return result
802+
self.log.error("Failure submitting Monitoring report", result["Message"])
804803

805804
return S_OK((pilotList, stampDict))
806805

0 commit comments

Comments
 (0)