Skip to content

Commit fa1fbc7

Browse files
authored
Merge pull request #5861 from TaykYoku/v7r2_fixhack-1
[v7r2] return standard result in PublisherHandler.getSite
2 parents cd90266 + 7c8a87b commit fa1fbc7

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

src/DIRAC/ResourceStatusSystem/Service/PublisherHandler.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -183,9 +183,10 @@ def export_getTree(self, elementType, elementName):
183183
finds its parent site and returns all descendants of that site.
184184
"""
185185

186-
site = self.getSite(elementType, elementName)
187-
if not site:
188-
return S_ERROR("No site")
186+
result = self.getSite(elementType, elementName)
187+
if not result["OK"]:
188+
return result
189+
site = result["Value"]
189190

190191
siteStatus = self.rsClient.selectStatusElement(
191192
"Site", "Status", name=site, meta={"columns": ["StatusType", "Status"]}
@@ -284,10 +285,10 @@ def getSite(self, elementType, elementName):
284285
if elementType == "StorageElement":
285286
elementType = "SE"
286287

287-
domainNames = gConfig.getSections("Resources/Sites")
288-
if not domainNames["OK"]:
289-
return domainNames
290-
domainNames = domainNames["Value"]
288+
result = gConfig.getSections("Resources/Sites")
289+
if not result["OK"]:
290+
return result
291+
domainNames = result["Value"]
291292

292293
for domainName in domainNames:
293294

@@ -299,9 +300,9 @@ def getSite(self, elementType, elementName):
299300

300301
elements = gConfig.getValue("Resources/Sites/%s/%s/%s" % (domainName, site, elementType), "")
301302
if elementName in elements:
302-
return site
303+
return S_OK(site)
303304

304-
return ""
305+
return S_ERROR("No site")
305306

306307
# ResourceManagementClient ...................................................
307308

0 commit comments

Comments
 (0)