style: replace unicorn/no-for-loop w/ typescript/prefer-for-of (#20798)

* style: replace unicorn/no-for-loop w/ typescript/prefer-for-of

* style: fix typescript-eslint/prefer-for-of

* style: fix typescript/no-inferrable-types

* style: fix typescript-eslint/consistent-generic-constructors

* style: typescript-eslint/consistent-type-assertions

* style: fix typescript-eslint/array-type

* fix: revert .entries() in d96ca62

Author: TonyRL

eslint.config.mjs

@@ -29,7 +29,7 @@ export default [
     {
         ignores: ['**/coverage', '**/.vscode', '**/docker-compose.yml', '!.github', 'assets/build', 'lib/routes-deprecated', 'lib/router.js', '**/babel.config.js', 'scripts/docker/minify-docker.js', 'dist', 'dist-lib'],
     },
-    ...compat.extends('eslint:recommended', 'plugin:yml/recommended', 'plugin:@typescript-eslint/recommended'),
+    ...compat.extends('eslint:recommended', 'plugin:yml/recommended', 'plugin:@typescript-eslint/recommended', 'plugin:@typescript-eslint/stylistic'),
     n.configs['flat/recommended-script'],
     unicorn.configs.recommended,
     {
@@ -147,8 +147,16 @@ export default [
             'require-await': 'error',
 
             // typescript
+            '@typescript-eslint/array-type': ['error', { default: 'array-simple' }],
+
             '@typescript-eslint/ban-ts-comment': 'off',
+            '@typescript-eslint/consistent-indexed-object-style': 'off', // stylistic
+            '@typescript-eslint/consistent-type-definitions': 'off', // stylistic
+            '@typescript-eslint/no-empty-function': 'off', // stylistic && tests
             '@typescript-eslint/no-explicit-any': 'off',
+
+            '@typescript-eslint/no-inferrable-types': ['error', { ignoreParameters: true, ignoreProperties: true }],
+
             '@typescript-eslint/no-var-requires': 'off',
 
             '@typescript-eslint/no-unused-expressions': [
@@ -167,6 +175,8 @@ export default [
                 },
             ],
 
+            '@typescript-eslint/prefer-for-of': 'error',
+
             // unicorn
             'unicorn/consistent-function-scoping': 'warn',
             'unicorn/explicit-length-check': 'off',
@@ -184,6 +194,7 @@ export default [
             'unicorn/no-array-sort': 'warn',
             'unicorn/no-await-expression-member': 'off',
             'unicorn/no-empty-file': 'warn',
+            'unicorn/no-for-loop': 'off',
             'unicorn/no-hex-escape': 'warn',
             'unicorn/no-null': 'off',
             'unicorn/no-object-as-default-parameter': 'warn',

lib/registry.ts

@@ -223,13 +223,13 @@ for (const namespace in namespaces) {
         continue;
     }
 
-    const sortedRoutes = Object.entries(namespaceData.apiRoutes) as [
+    const sortedRoutes = Object.entries(namespaceData.apiRoutes) as Array<[
         string,
         APIRoute & {
             location: string;
             module?: () => Promise<{ apiRoute: APIRoute }>;
         },
-    ][];
+    ]>;
 
     for (const [path, routeData] of sortedRoutes) {
         const wrappedHandler: Handler = async (ctx) => {

lib/routes-deprecated/lolapp/article.js

@@ -10,8 +10,8 @@ module.exports = async (ctx) => {
     const name = data[0].feedNews.footer.source;
     const newData = [];
     let pubDate = [];
-    for (const [i, datum] of data.entries()) {
-        newData[i] = datum.feedNews.body;
+    for (let i = 0; i < data.length; i++) {
+        newData[i] = data[i].feedNews.body;
         newData[i].link = 'https://mlol.qt.qq.com/go/mlol_news/varcache_article?is_lqt=true&docid=' + newData[i].commentID;
         pubDate[i] = getPublishedDate(newData[i].link);
     }

lib/routes.test.ts

@@ -51,7 +51,7 @@ async function checkRSS(response) {
     checkDate(parsed.lastBuildDate);
 
     // check items
-    const guids: (string | undefined)[] = [];
+    const guids: Array<string | undefined> = [];
     for (const item of parsed.items) {
         expect(item).toEqual(expect.any(Object));
         expect(item.title).toEqual(expect.any(String));

lib/routes/0xxx/index.ts

@@ -15,7 +15,7 @@ export const handler = async (ctx: Context): Promise<Data> => {
     const { filter } = ctx.req.param();
     const limit: number = Number.parseInt(ctx.req.query('limit') ?? '100', 10);
 
-    const baseUrl: string = 'https://0xxx.ws';
+    const baseUrl = 'https://0xxx.ws';
     const targetUrl: string = new URL(filter ? `?${filter}` : '', baseUrl).href;
 
     const response = await ofetch(targetUrl);

lib/routes/10000link/info.ts

@@ -15,7 +15,7 @@ export const handler = async (ctx: Context): Promise<Data> => {
     const { category = 'newslists', id } = ctx.req.param();
     const limit: number = Number.parseInt(ctx.req.query('limit') ?? '30', 10);
 
-    const baseUrl: string = 'https://info.10000link.com';
+    const baseUrl = 'https://info.10000link.com';
     const targetUrl: string = new URL(`${category}.aspx${id ? `?chid=${id}` : ''}`, baseUrl).href;
 
     const response = await ofetch(targetUrl);
@@ -109,7 +109,7 @@ export const handler = async (ctx: Context): Promise<Data> => {
         )
     ).filter((_): _ is DataItem => true);
 
-    const author: string = '10000万联网';
+    const author = '10000万联网';
     const title: string = $('h1').contents().first().text();
 
     return {

lib/routes/121/weather-live.tsx

@@ -27,8 +27,8 @@ const renderDescription = (description, images) =>
 export const handler = async (ctx: Context): Promise<Data> => {
     const limit: number = Number.parseInt(ctx.req.query('limit') ?? '100', 10);
 
-    const baseUrl: string = 'https://tf.121.com.cn';
-    const imgBaseUrl: string = 'https://wx.121.com.cn';
+    const baseUrl = 'https://tf.121.com.cn';
+    const imgBaseUrl = 'https://wx.121.com.cn';
     const targetUrl: string = new URL('web/weatherLive/', baseUrl).href;
     const apiUrl: string = new URL('weather/weibo/message.js', baseUrl).href;
 
@@ -52,7 +52,7 @@ export const handler = async (ctx: Context): Promise<Data> => {
             );
             const pubDate: number | string = item.DDatetime;
             const linkUrl: string | undefined = targetUrl;
-            const guid: string = `121-${title}-${pubDate}`;
+            const guid = `121-${title}-${pubDate}`;
             const image: string | undefined = item.Img?.length > 0 ? new URL(`WeChat/data/weiweb/images/lwspic/${item.Img[0]}`, imgBaseUrl).href : undefined;
             const updated: number | string = pubDate;
 

lib/routes/199it/index.tsx

@@ -14,7 +14,7 @@ export const handler = async (ctx: Context): Promise<Data> => {
     const { category = 'newly' } = ctx.req.param();
     const limit: number = Number.parseInt(ctx.req.query('limit') ?? '30', 10);
 
-    const baseUrl: string = 'https://www.199it.com';
+    const baseUrl = 'https://www.199it.com';
     const targetUrl: string = new URL(category, baseUrl).href;
 
     const response = await ofetch(targetUrl);

lib/routes/21caijing/channel.ts

@@ -45,9 +45,9 @@ export const handler = async (ctx: Context): Promise<Data> => {
     const { name = '热点' } = ctx.req.param();
     const limit: number = Number.parseInt(ctx.req.query('limit') ?? '30', 10);
 
-    const domain: string = 'm.21jingji.com';
-    const baseUrl: string = `https://${domain}`;
-    const staticBaseUrl: string = 'https://static.21jingji.com';
+    const domain = 'm.21jingji.com';
+    const baseUrl = `https://${domain}`;
+    const staticBaseUrl = 'https://static.21jingji.com';
     const menuUrl: string = new URL('m/webMenu.json', staticBaseUrl).href;
 
     const menuResponse = await ofetch(menuUrl);
@@ -97,7 +97,7 @@ export const handler = async (ctx: Context): Promise<Data> => {
             const authors: DataItem['author'] = [...new Set([item.mp?.name, item.author, item.editor, item.source].filter(Boolean))].map((name) => ({
                 name,
             }));
-            const guid: string = `21jingji-${item.id}`;
+            const guid = `21jingji-${item.id}`;
             const image: string | undefined = item.image ?? item.thumb ?? item.listthumb;
             const updated: number | string = item.updatetime;
 

lib/routes/5eplay/utils.ts

@@ -16,11 +16,10 @@ const getAcwScV2ByArg1 = (arg1) => {
     const unsbox = function (str: string) {
         const code = [15, 35, 29, 24, 33, 16, 1, 38, 10, 9, 19, 31, 40, 27, 22, 23, 25, 13, 6, 11, 39, 18, 20, 8, 14, 21, 32, 26, 2, 30, 7, 4, 17, 5, 3, 28, 34, 37, 12, 36];
         const res: string[] = [];
-        // eslint-disable-next-line unicorn/no-for-loop
         for (let i = 0; i < str.length; i++) {
             const cur = str[i];
-            for (const [j, element] of code.entries()) {
-                if (element === i + 1) {
+            for (let j = 0; j < code.length; j++) {
+                if (code[j] === i + 1) {
                     res[j] = cur;
                 }
             }