fix(backend): Throw error on incorrect password

Author: whyredfire

backend/src/SlcmSwitch.py

@@ -4,7 +4,7 @@
 from bs4 import BeautifulSoup
 from httpx import AsyncClient
 
-from .models import SlcmCookies, SlcmCookiesWithName
+from .models import IncorrectPassword, SlcmCookies, SlcmCookiesWithName
 
 
 class SlcmSwitch:
@@ -77,6 +77,9 @@ async def student_login(self, username: str, password: str) -> SlcmCookiesWithNa
                 follow_redirects=False,
             )
 
+            if res.status_code != 302:
+                raise IncorrectPassword()
+
             return SlcmCookiesWithName(
                 verification_token=cookies.verification_token,
                 asp_net_id=res.cookies["ASP.NET_SessionId"],

backend/src/main.py

@@ -1,8 +1,7 @@
 import uvicorn
-from fastapi import FastAPI, HTTPException
-from fastapi.encoders import jsonable_encoder
+from fastapi import FastAPI
 from fastapi.middleware.cors import CORSMiddleware
-from fastapi.responses import JSONResponse, RedirectResponse
+from fastapi.responses import RedirectResponse
 
 from .routes import router
 
@@ -18,13 +17,6 @@
 )
 
 
-@app.exception_handler(HTTPException)
-async def validation_exception_handler(exc: HTTPException):
-    return JSONResponse(
-        status_code=exc.status_code, content=jsonable_encoder(exc.detail)
-    )
-
-
 @app.get("/")
 async def redirect():
     return RedirectResponse("https://github.com/whyredfire/betterslcm")

backend/src/models.py

@@ -31,3 +31,7 @@ class StudentLogin(ParentLogin):
 
 class ParentLoginOTP(SlcmCookies):
     otp: str = Field(..., description="The OTP for the login")
+
+
+class IncorrectPassword(Exception):
+    pass

backend/src/routes.py

@@ -1,6 +1,6 @@
-from fastapi import APIRouter
+from fastapi import APIRouter, HTTPException
 
-from .models import ParentLogin, SlcmCookies, StudentLogin
+from .models import IncorrectPassword, ParentLogin, SlcmCookies, StudentLogin
 from .SlcmSwitch import SlcmSwitch
 
 router = APIRouter()
@@ -9,8 +9,11 @@
 
 @router.post("/login/student")
 async def student_login(login: StudentLogin) -> dict[str, str]:
-    cookies = await slcm.student_login(login.username, login.password)
-    return cookies.model_dump(by_alias=True)
+    try:
+        cookies = await slcm.student_login(login.username, login.password)
+        return cookies.model_dump(by_alias=True)
+    except IncorrectPassword:
+        raise HTTPException(status_code=401, detail="Incorrect Password")
 
 
 @router.post("/login/parent")