Skip to content

Commit 6b6cc85

Browse files
Cleanup add support for PHP 8.4
1 parent 66bffaf commit 6b6cc85

File tree

2 files changed

+29
-15
lines changed

2 files changed

+29
-15
lines changed

.github/workflows/php.yml

Lines changed: 22 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ jobs:
2525
- "8.1"
2626
- "8.2"
2727
- "8.3"
28+
- "8.4"
2829

2930
steps:
3031
-
@@ -41,21 +42,22 @@ jobs:
4142
run: "composer validate --strict"
4243
-
4344
name: "Determine composer cache directory"
44-
id: "determine-composer-cache-directory"
45-
run: "echo \"::set-output name=directory::$(composer config cache-dir)\""
45+
id: composer-cache
46+
run: |
47+
echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
4648
-
4749
name: "Cache dependencies installed with composer"
4850
uses: "actions/cache@v4"
4951
with:
50-
path: "${{ steps.determine-composer-cache-directory.outputs.directory }}"
52+
path: ${{ steps.composer-cache.outputs.dir }}
5153
key: "php-${{ matrix.php-version }}-composer-${{ hashFiles('composer.lock') }}"
5254
restore-keys: "php-${{ matrix.php-version }}-composer-"
5355
-
5456
name: "Install composer dependencies"
5557
run: "composer install --no-interaction --no-progress --no-suggest"
5658
-
5759
name: "Run Linter"
58-
run: "composer lint:php"
60+
run: "composer lint"
5961

6062
php-qs:
6163
name: "PHP QS"
@@ -78,7 +80,11 @@ jobs:
7880
- "8.1"
7981
- "8.2"
8082
- "8.3"
81-
83+
- "8.4"
84+
### Exclude PHP 8.4 for php-c-fixers as there is currently no support
85+
exclude:
86+
- command: "test:phpcs"
87+
php-version: "8.4"
8288
steps:
8389
-
8490
name: "Checkout"
@@ -94,13 +100,14 @@ jobs:
94100
run: "composer validate --strict"
95101
-
96102
name: "Determine composer cache directory"
97-
id: "determine-composer-cache-directory"
98-
run: "echo \"::set-output name=directory::$(composer config cache-dir)\""
103+
id: composer-cache
104+
run: |
105+
echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
99106
-
100107
name: "Cache dependencies installed with composer"
101108
uses: "actions/cache@v4"
102109
with:
103-
path: "${{ steps.determine-composer-cache-directory.outputs.directory }}"
110+
path: ${{ steps.composer-cache.outputs.dir }}
104111
key: "php-${{ matrix.php-version }}-composer-${{ hashFiles('composer.lock') }}"
105112
restore-keys: "php-${{ matrix.php-version }}-composer-"
106113
-
@@ -146,6 +153,9 @@ jobs:
146153
-
147154
typo3-version: "^12.4"
148155
php-version: "8.3"
156+
-
157+
typo3-version: "^12.4"
158+
php-version: "8.4"
149159

150160
steps:
151161
-
@@ -162,13 +172,14 @@ jobs:
162172
run: "composer validate --strict"
163173
-
164174
name: "Determine composer cache directory"
165-
id: "determine-composer-cache-directory"
166-
run: "echo \"::set-output name=directory::$(composer config cache-dir)\""
175+
id: composer-cache
176+
run: |
177+
echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
167178
-
168179
name: "Cache dependencies installed with composer"
169180
uses: "actions/cache@v4"
170181
with:
171-
path: "${{ steps.determine-composer-cache-directory.outputs.directory }}"
182+
path: ${{ steps.composer-cache.outputs.dir }}
172183
key: "php-${{ matrix.php-version }}-composer-${{ hashFiles('composer.lock') }}"
173184
restore-keys: "php-${{ matrix.php-version }}-composer-"
174185
-

composer.json

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
"issues": "https://github.com/DMKEBUSINESSGMBH/typo3-mkcache_queue"
2222
},
2323
"require" : {
24-
"php": "^7.4 || ^8.0 || ^8.1 || ^8.2 || ^8.3",
2524
"typo3/cms-core" : "^11.5.7 || ^12.4"
2625
},
2726
"require-dev": {
@@ -90,14 +89,15 @@
9089
"@lint:php"
9190
],
9291
"test:phpcs": [
93-
".Build/bin/php-cs-fixer fix -v --dry-run --diff"
92+
"PHP_CS_FIXER_IGNORE_ENV=1 .Build/bin/php-cs-fixer fix -v --dry-run --diff"
9493
],
9594
"test:phpcompatibility": [
9695
"@test:phpcompatibility:7.4",
9796
"@test:phpcompatibility:8.0",
9897
"@test:phpcompatibility:8.1",
9998
"@test:phpcompatibility:8.2",
100-
"@test:phpcompatibility:8.3"
99+
"@test:phpcompatibility:8.3",
100+
"@test:phpcompatibility:8.4"
101101
],
102102
"test:phpcompatibility:7.4": [
103103
".Build/bin/phpcs --ignore=.Build/*,Resources/Public/* -p . --standard=.Build/vendor/phpcompatibility/php-compatibility/PHPCompatibility --runtime-set testVersion 7.4"
@@ -114,6 +114,9 @@
114114
"test:phpcompatibility:8.3": [
115115
".Build/bin/phpcs --ignore=.Build/*,Resources/Public/* -p . --standard=.Build/vendor/phpcompatibility/php-compatibility/PHPCompatibility --runtime-set testVersion 8.3"
116116
],
117+
"test:phpcompatibility:8.4": [
118+
".Build/bin/phpcs --ignore=.Build/*,Resources/Public/* -p . --standard=.Build/vendor/phpcompatibility/php-compatibility/PHPCompatibility --runtime-set testVersion 8.4"
119+
],
117120
"test:phpmd": [
118121
".Build/bin/phpmd ./Classes text phpmd.xml"
119122
],
@@ -139,7 +142,7 @@
139142
"@test:phpunit"
140143
],
141144
"fix:phpcs": [
142-
".Build/bin/php-cs-fixer fix -v"
145+
"PHP_CS_FIXER_IGNORE_ENV=1 .Build/bin/php-cs-fixer fix -v"
143146
],
144147
"fix": [
145148
"@pre-qs",

0 commit comments

Comments
 (0)