Skip to content

Commit 9cf3401

Browse files
Cleanup fix rector findings
1 parent 2aff48e commit 9cf3401

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

Classes/Plugin.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ protected function buildScriptOptions(): string
424424

425425
$paramsString = '';
426426
foreach ($options as $param => $value) {
427-
if (strlen((string) $value) > 0) {
427+
if ('' !== (string) $value) {
428428
$value = escapeshellarg((string) $value);
429429
}
430430

Tests/Classes/PluginTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,6 @@ public function testGetUrlsWithUrlsFromTypoScriptWhenConfigurationIsString(): vo
249249
}
250250

251251
/**
252-
* @param string $allowedHostsConfiguration
253252
* @param array || boolean $expectedAllowedHostsForUtilityMethod
254253
*
255254
* @group unit
@@ -258,8 +257,8 @@ public function testGetUrlsWithUrlsFromTypoScriptWhenConfigurationIsString(): vo
258257
*/
259258
#[DataProvider('dataProviderSanitizeUrls')]
260259
public function testSanitizeUrlsWithoutFrontendUser(
261-
$allowedHostsConfiguration,
262-
$expectedAllowedHostsForUtilityMethod,
260+
string $allowedHostsConfiguration,
261+
array $expectedAllowedHostsForUtilityMethod,
263262
): void {
264263
$utility = $this->getMockBuilder(Utility::class)
265264
->onlyMethods(['sanitizeUrl'])

0 commit comments

Comments
 (0)