Skip to content

Commit 2817405

Browse files
authored
Merge pull request #3566 from DMPRoadmap/aaron/bump-ruby-v3.1.4
Bump Ruby to v3.1.4 and use `.ruby-version` in CI
2 parents bfbb518 + 3664410 commit 2817405

File tree

10 files changed

+10
-11
lines changed

10 files changed

+10
-11
lines changed

.github/workflows/danger.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ jobs:
1818
- name: 'Install Ruby'
1919
uses: ruby/setup-ruby@v1
2020
with:
21-
ruby-version: ${{ env.RUBY_VERSION }}
2221

2322
- name: 'Bundle Install'
2423
run: |

.github/workflows/mysql.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ jobs:
1919
# Install Ruby and run bundler
2020
- uses: ruby/setup-ruby@v1
2121
with:
22-
ruby-version: '3.0'
2322
bundler-cache: true
2423

2524
# Install Node

.github/workflows/postgres.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ jobs:
3636
# Install Ruby and run bundler
3737
- uses: ruby/setup-ruby@v1
3838
with:
39-
ruby-version: '3.0'
4039
bundler-cache: true
4140

4241
## - run: echo 'NODE_OPTIONS="--openssl-legacy-provider"' >> $GITHUB_ENV

.github/workflows/rubocop.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ jobs:
1313
# Install Ruby and run bundler
1414
- uses: ruby/setup-ruby@v1
1515
with:
16-
ruby-version: '3.0'
1716
bundler-cache: true
1817

1918
# Run the Rubocop linter checks

.gitignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
# Ignore rbenv files
2-
.ruby-version
3-
41
# Ignore bundler config
52
/.bundle
63

.ruby-version

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
3.1.4

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Changelog
22

3+
## v5.0.2
4+
- Bump Ruby to v3.1.4 and use `.ruby-version` in CI [#3566](https://github.com/DMPRoadmap/roadmap/pull/3566)
5+
36
## v5.0.1
47
- Updated seeds.rb file for identifier_schemes to include context value and removed logo_url and idenitifier_prefix for Shibboleth (as it was causing issues with SSO). [#3525](https://github.com/DMPRoadmap/roadmap/pull/3525)
58
- Adjustments to style of select tags and plan download layout [#3509](https://github.com/DMPRoadmap/roadmap/pull/3509)

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
source 'https://rubygems.org'
44

5-
ruby '>= 3.0'
5+
ruby '3.1.4'
66

77
# ===========#
88
# CORE RAILS #

Gemfile.lock

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,8 @@ GEM
210210
faraday (>= 0.8)
211211
faraday-net_http (3.4.0)
212212
net-http (>= 0.5.0)
213-
ffi (1.17.1)
213+
ffi (1.17.1-arm64-darwin)
214+
ffi (1.17.1-x86_64-linux-gnu)
214215
flag_shih_tzu (0.3.23)
215216
fog-aws (3.30.0)
216217
base64 (~> 0.2.0)
@@ -696,7 +697,7 @@ DEPENDENCIES
696697
yard-tomdoc
697698

698699
RUBY VERSION
699-
ruby 3.0.4p208
700+
ruby 3.1.4p223
700701

701702
BUNDLED WITH
702703
2.4.17

app/controllers/plans_controller.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,8 @@ def show
193193
@default_orgs = Org.default_orgs
194194
@all_ggs_grouped_by_org.each do |org, ggs|
195195
# @default_orgs and already selected guidance groups are important.
196-
if (@default_orgs.include?(org) || (ggs & @selected_guidance_groups).any?) && !@important_ggs.include?([org, ggs])
196+
if (@default_orgs.include?(org) || ggs.intersect?(@selected_guidance_groups)) && !@important_ggs.include?([org,
197+
ggs])
197198
@important_ggs << [org, ggs]
198199
end
199200
end

0 commit comments

Comments
 (0)